Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use released deps. #22

Merged
merged 7 commits into from
Mar 9, 2020
Merged

Use released deps. #22

merged 7 commits into from
Mar 9, 2020

Conversation

dvc94ch
Copy link
Collaborator

@dvc94ch dvc94ch commented Mar 6, 2020

Fixes a few issues and precursor to adding it as a dependency to rust-ipfs

@dvc94ch dvc94ch mentioned this pull request Mar 6, 2020
Closed
vmx
vmx reviewed Mar 6, 2020
View reviewed changes
Copy link
Member

@vmx vmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I'd wait for the new rust-cid release as it will also contain the getters of the CID.

@dvc94ch
Copy link
Collaborator Author

dvc94ch commented Mar 6, 2020 •
edited
Loading

can we get the arbitraries in too? Doesn't really matter, I'll just impl it myself

@dvc94ch dvc94ch mentioned this pull request Mar 6, 2020
Closed
@vmx vmx mentioned this pull request Mar 6, 2020
Closed
vmx
vmx reviewed Mar 6, 2020
View reviewed changes
Copy link
Member

@vmx vmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good. I'd just wait for a new release of rust-cid as it would break things again (due to using getters for the CID.

@vmx
Copy link
Member

vmx commented Mar 9, 2020

I released rust-cid 0.4.

@dvc94ch dvc94ch merged commit 6230c22 into ipld:master Mar 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vmx vmx vmx left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dvc94ch @vmx