Add L2 vxlan for SR Linux; requires evpn #329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! Per-platform 'requires' attribute sounds like an interesting addition. In the meantime, we should solve the challenge with device feature flags ( Will merge this (and the next) PR and make those changes when I get back home. Please give me a few more days. |
Per-device requirements are now handled in generic module code
VXLAN/EVPN dependency is now handled with global per-device module requirements
|
Made the necessary adjustments directly in this branch and merged the changes. Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #324
On SR Linux, VXLAN requires EVPN; it might be more elegant to allow a per-platform override of the 'requires' attribute for a module, but for now I've added a 'requires_evpn' flag which is set to True on SR Linux