Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix clab mgmt network #462

Merged
merged 2 commits into from
Sep 19, 2022
Merged

Fix clab mgmt network #462

merged 2 commits into from
Sep 19, 2022

Conversation

jbemmel
Copy link
Collaborator

@jbemmel jbemmel commented Sep 18, 2022

Adhere to the management network settings provided by Netlab, instead of using Containerlab defaults

Specifically, the Netlab default is ipv4-only while Containerlab provides ipv4+ipv6 by default.

ipspace
ipspace approved these changes Sep 19, 2022
View reviewed changes
Copy link
Owner

@ipspace ipspace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one. Now we could also unify the "netlab connect" logic so it doesn't have to use clab hostnames to connect to devices.

@ipspace ipspace mentioned this pull request Sep 19, 2022
Closed
@ipspace ipspace merged commit 7ac63f4 into ipspace:dev Sep 19, 2022
ipspace pushed a commit that referenced this pull request Oct 1, 2022
@jbemmel @ipspace
Use static IPv4/IPv6 addresses on clab management network (#462)
a8d831f
@jbemmel jbemmel deleted the fix-clab-mgmt-network branch November 5, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ipspace ipspace ipspace approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jbemmel @ipspace