Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename some matching_scoring_test tests #37

Closed
riley-harper opened this issue Aug 2, 2022 · 1 comment
Closed

Rename some matching_scoring_test tests #37

riley-harper opened this issue Aug 2, 2022 · 1 comment
Labels
tests Unit and integration tests for code

Comments

@riley-harper
Copy link
Contributor

riley-harper commented Aug 2, 2022 •
edited
Loading

The tests test_step_3_skip_on_no_conf() and test_step_3_alpha_beta_thresholds() in matching_scoring_test.py both mention Matching step 3, which doesn't exist. I believe they're both testing Matching step 2, so we should rename them to line up with that. They both have TODO comments above them as reminders.
@riley-harper riley-harper added the tests Unit and integration tests for code label Aug 2, 2022
@riley-harper
Copy link
Contributor Author

#139 fixed this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tests Unit and integration tests for code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@riley-harper