Unskip several skipped tests #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
model_exploration_test.test_step_3_get_feature_importances_random_forest is covered by tests for training step 3 in training_test.py.
This tests Training step 3 with a probit model instead of a random forest model. Probit models save coefficients, not feature importances.
This required some heavy refactoring. I think that this test was really old. The new checks are very similar to the checks in the old test.
Reading the comment at the top of this test, I went looking for something that directly replaced the "secondary_threshold" matching attribute. I couldn't find anything that looked closely related. So let's just remove this test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #21.
This PR rewrites 2 skipped tests and removes the other 2. I added some detailed commit messages with reasons for rewriting or removing each test. Now all of the tests should be running and passing.
This PR also makes a few small changes to other tests, removing debugging code or renaming tests with incorrect names.