Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for id column in config validation should be case-insensitive #39

Closed
riley-harper opened this issue Sep 13, 2022 · 0 comments · Fixed by #41
Closed

Check for id column in config validation should be case-insensitive #39

riley-harper opened this issue Sep 13, 2022 · 0 comments · Fixed by #41
Labels
bug Something isn't working

Comments

@riley-harper
Copy link
Contributor

riley-harper commented Sep 13, 2022

The case of column names doesn't matter to hlink. So the check in hlink.scripts.lib.conf_validations.check_datasource should be case-insensitive so that it doesn't throw spurious errors when the id column name is capitalized differently in the config file and the datasources.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant