Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address a few small conf_validations issues #13

Merged
merged 7 commits into from
Aug 1, 2022

Conversation

riley-harper
Copy link
Contributor

This PR fixes a few issues in conf_validations:

  • Added an f to a string that expected to be formatted but wasn't being formatted.
  • Added a check to analyze_conf() to make sure that both data sources contain the id_column.
  • Refactored some testing structure to allow for testing conf_validations more easily. This involved moving some files from the hlink_config directory, which I've now deleted, to hlink/tests/conf and creating a new hlink/tests/input_data/conf_validation directory. The config files used for testing conf_validations reference their datasource files in hlink/tests/input_data/conf_validation by relative paths from the root project directory.

@riley-harper riley-harper marked this pull request as ready for review July 29, 2022 21:14
@jacwellington
Copy link
Collaborator

This looks great!

@jacwellington jacwellington merged commit 9bb9348 into main Aug 1, 2022
@jacwellington jacwellington deleted the conf_validation_tweaks branch August 1, 2022 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants