Create a separate log file for each run of hlink #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… a "log_file" attribute This lets us decide what to name the log file later in main._setup_logging(). This will be helpful when we want to change the name of the log for each hlink run. This also slightly changes the current logging setup. It creates a logs/ subdirectory and outputs logs to an hlink.log file in that subdirectory.
The name of the file is {conf_name}-{session_id}, where session_id is the hexadecimal
representation of a uuid for the run.
I also changed the log header because now there's one per file and we don't need to block
it off from the surrounding text as much.
jacwellington
approved these changes
Nov 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #54.
This PR updates hlink's main script to log to a separate file for each run instead of always logging to the same file. The name of the log file is
{conf_name}-{session_id}.log, wheresession_idis the hexadecimal representation of a uuid generated for the run. Each log file is placed in the same directory, namedlogs/. The location of thislogs/directory depends on whether a global configuration file is provided with the HLINK_CONF environment variable or not.This changes
main.load_conf()so that it adds the key"log_dir"to the config dictionary instead of"log_file". This isn't a big deal, as the only other place that uses these keys ismain._setup_logging().