Log user input in the main loop #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This provides additional context for errors and other logging information. It filters out input that's just whitespace to avoid flooding the logs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #57.
This is a small PR that updates the main loop to log user commands when they are input. This makes use of the
precmdhook, which is called after input is received and before it is parsed and commands executed. To avoid flooding the logs with unhelpful information, I filtered out lines that are only whitespace so that they are not logged.After considering a few different formats for logging user input, I settled on a format like
[User Input] run_all_steps preprocessing matching, which I find fairly easy to read and also easily distinguishable from other log lines.