-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Swarm Bootstrap Nodes #201
Conversation
Codecov Report
@@ Coverage Diff @@
## main #201 +/- ##
==========================================
+ Coverage 75.20% 75.25% +0.04%
==========================================
Files 65 65
Lines 6107 6135 +28
==========================================
+ Hits 4593 4617 +24
- Misses 1514 1518 +4
|
47e4e1d
to
b2e0f00
Compare
tests will probably fail at the moment since i havent setup nix properly on my laptop yet. needed to get this change uploaded though. |
Ok, putting together some additional work here @mriise, to close this out:
|
Signed-off-by: Melanie Riise <me@mriise.net>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mriise some minor cleanup mentions here and a suggestion for startup
cleanup.
@mriise I'm about to push a small reworking of when scheduling runs vs the ahead-of-time parsing. Let's try to get the last few bits lined up for this one and get it in. I know you've been pushing to the other branch as well :). |
ci shouldn't be failing like this... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work @mriise!
Description
Adds bootstrap nodes in settings that will be connected to on node startup.
Link to issue
Please add a link to any relevant issues/tickets.
Type of change
Please delete options that are not relevant.
Test plan (required)
Parsing testing is added with the other settings test. Tests actually dialing nodes will be added in a different PR since this is a perquisite to gossip/receipt testing anyways.