fix: make configuration run without -c (all defaults) #433

zeeshanlakhani · 2023-11-14T04:04:29Z

Includes:

also, add starter functions for default .pem/settings initialization
error handling around retry, wasms
ups the transport timeout

Includes: - also, add starter fns for default .pem/settings initialization

bgins

Looks good! Some nice DX improvements here. 💯

Includes: - also, add starter functions for default .pem/settings initialization - error handling around retry, wasms - ups the transport timeout

## Description Includes: - re-purposing of feature flags * metrics is always a thing (on) * monitoring is the gated feature * The websocket-server flag is gone, we only gate push notifications - JSON-RPC setup and RPC method register - Prometheus exposition format to JSON parser Other features and other fixes: - [x] e2e testing of run workflow - [x] #407 - [x] #410 - [x] #418 - [x] #424 - [x] #354 - [x] #409 - [x] #425 - [x] #426 - [x] #429 - [x] #433 - [x] #435 - [x] #421 - [x] #436 - [x] #437 - [x] #444 - [x] #438 - [x] #390 - [x] #451 - [x] #456 --------- Signed-off-by: Brian Ginsburg <7957636+bgins@users.noreply.github.com> Signed-off-by: Zeeshan Lakhani <zeeshan.lakhani@gmail.com> Co-authored-by: Brian Ginsburg <7957636+bgins@users.noreply.github.com> Co-authored-by: Hugo Dias <hugomrdias@gmail.com>

Includes: - re-purposing of feature flags * metrics is always a thing (on) * monitoring is the gated feature * The websocket-server flag is gone, we only gate push notifications - JSON-RPC setup and RPC method register - Prometheus exposition format to JSON parser Other features and other fixes: - [x] e2e testing of run workflow - [x] #407 - [x] #410 - [x] #418 - [x] #424 - [x] #354 - [x] #409 - [x] #425 - [x] #426 - [x] #429 - [x] #433 - [x] #435 - [x] #421 - [x] #436 - [x] #437 - [x] #444 - [x] #438 - [x] #390 - [x] #451 - [x] #456 --------- Signed-off-by: Brian Ginsburg <7957636+bgins@users.noreply.github.com> Signed-off-by: Zeeshan Lakhani <zeeshan.lakhani@gmail.com> Co-authored-by: Brian Ginsburg <7957636+bgins@users.noreply.github.com> Co-authored-by: Hugo Dias <hugomrdias@gmail.com>

fix: make configuration run without -c (all defaults)

75cf9a3

Includes: - also, add starter fns for default .pem/settings initialization

zeeshanlakhani requested a review from a team as a code owner November 14, 2023 04:04

chore: error handling around retry, wasms

433b46a

zeeshanlakhani force-pushed the zl/default-config+fns-for-.config branch from d5e37f5 to 433b46a Compare November 14, 2023 17:14

chore: logs

2429bfe

bgins approved these changes Nov 14, 2023

View reviewed changes

zeeshanlakhani merged commit 73ec736 into zl/jsonrpc Nov 14, 2023
34 checks passed

zeeshanlakhani deleted the zl/default-config+fns-for-.config branch November 14, 2023 21:22

bgins mentioned this pull request Nov 16, 2023

jsonrpc-feature returned #417

Merged

20 tasks

zeeshanlakhani pushed a commit that referenced this pull request Nov 29, 2023

fix: make configuration run without -c (all defaults) (#433)

11a8f88

Includes: - also, add starter functions for default .pem/settings initialization - error handling around retry, wasms - ups the transport timeout

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: make configuration run without -c (all defaults) #433

fix: make configuration run without -c (all defaults) #433

zeeshanlakhani commented Nov 14, 2023 •

edited

Loading

bgins left a comment

fix: make configuration run without -c (all defaults) #433

fix: make configuration run without -c (all defaults) #433

Conversation

zeeshanlakhani commented Nov 14, 2023 • edited Loading

bgins left a comment

Choose a reason for hiding this comment

zeeshanlakhani commented Nov 14, 2023 •

edited

Loading