Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: schedule + db conflict #437

Merged
merged 4 commits into from
Nov 15, 2023
Merged

fix: schedule + db conflict #437

merged 4 commits into from
Nov 15, 2023

Conversation

zeeshanlakhani
Copy link
Contributor

No description provided.

@zeeshanlakhani zeeshanlakhani requested a review from a team as a code owner November 15, 2023 20:41
bgins
bgins approved these changes Nov 15, 2023
View reviewed changes
Copy link
Contributor

@bgins bgins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested these changes running workflows across a couple of nodes, gossiping receipts and with replayed workflows. Works well, found no issues.

@zeeshanlakhani zeeshanlakhani merged commit cca7581 into zl/jsonrpc Nov 15, 2023
2 of 13 checks passed
@zeeshanlakhani zeeshanlakhani deleted the zl/fix-bottom-up branch November 15, 2023 22:34
@bgins bgins mentioned this pull request Nov 16, 2023
Merged
20 tasks
zeeshanlakhani pushed a commit that referenced this pull request Nov 29, 2023
@zeeshanlakhani
fix: schedule + db conflict (#437)
ce0c49f
bgins added a commit that referenced this pull request Nov 29, 2023
@bgins @hugomrdias
jsonrpc-feature returned (#417)
ac9167c 
## Description

Includes:
  - re-purposing of feature flags 
    * metrics is always a thing (on) 
    * monitoring is the gated feature 
    * The websocket-server flag is gone, we only gate push notifications
  - JSON-RPC setup and RPC method register
  - Prometheus exposition format to JSON parser

Other features and other fixes:

- [x] e2e testing of run workflow
- [x] #407
- [x] #410
- [x] #418
- [x] #424
- [x] #354 
- [x] #409
- [x] #425 
- [x] #426
- [x] #429 
- [x] #433
- [x] #435
- [x] #421
- [x] #436
- [x] #437
- [x] #444
- [x] #438
- [x] #390
- [x] #451 
- [x] #456

---------

Signed-off-by: Brian Ginsburg <7957636+bgins@users.noreply.github.com>
Signed-off-by: Zeeshan Lakhani <zeeshan.lakhani@gmail.com>
Co-authored-by: Brian Ginsburg <7957636+bgins@users.noreply.github.com>
Co-authored-by: Hugo Dias <hugomrdias@gmail.com>
bgins added a commit that referenced this pull request Nov 29, 2023
@bgins @hugomrdias
feat: Add JSON-PRC API (#417)
9b67136 
Includes:
  - re-purposing of feature flags
    * metrics is always a thing (on)
    * monitoring is the gated feature
    * The websocket-server flag is gone, we only gate push notifications
  - JSON-RPC setup and RPC method register
  - Prometheus exposition format to JSON parser

Other features and other fixes:

- [x] e2e testing of run workflow
- [x] #407
- [x] #410
- [x] #418
- [x] #424
- [x] #354
- [x] #409
- [x] #425
- [x] #426
- [x] #429
- [x] #433
- [x] #435
- [x] #421
- [x] #436
- [x] #437
- [x] #444
- [x] #438
- [x] #390
- [x] #451
- [x] #456

---------

Signed-off-by: Brian Ginsburg <7957636+bgins@users.noreply.github.com>
Signed-off-by: Zeeshan Lakhani <zeeshan.lakhani@gmail.com>
Co-authored-by: Brian Ginsburg <7957636+bgins@users.noreply.github.com>
Co-authored-by: Hugo Dias <hugomrdias@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bgins bgins bgins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zeeshanlakhani @bgins