fix: remove unnecessary decode #438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeeshanlakhani
pushed a commit
that referenced
this pull request
Nov 29, 2023
Fix: remove unnecessary decode of already utf8-ed string from wasmval.
bgins
added a commit
that referenced
this pull request
Nov 29, 2023
## Description
Includes:
- re-purposing of feature flags
* metrics is always a thing (on)
* monitoring is the gated feature
* The websocket-server flag is gone, we only gate push notifications
- JSON-RPC setup and RPC method register
- Prometheus exposition format to JSON parser
Other features and other fixes:
- [x] e2e testing of run workflow
- [x] #407
- [x] #410
- [x] #418
- [x] #424
- [x] #354
- [x] #409
- [x] #425
- [x] #426
- [x] #429
- [x] #433
- [x] #435
- [x] #421
- [x] #436
- [x] #437
- [x] #444
- [x] #438
- [x] #390
- [x] #451
- [x] #456
---------
Signed-off-by: Brian Ginsburg <7957636+bgins@users.noreply.github.com>
Signed-off-by: Zeeshan Lakhani <zeeshan.lakhani@gmail.com>
Co-authored-by: Brian Ginsburg <7957636+bgins@users.noreply.github.com>
Co-authored-by: Hugo Dias <hugomrdias@gmail.com>
bgins
added a commit
that referenced
this pull request
Nov 29, 2023
Includes:
- re-purposing of feature flags
* metrics is always a thing (on)
* monitoring is the gated feature
* The websocket-server flag is gone, we only gate push notifications
- JSON-RPC setup and RPC method register
- Prometheus exposition format to JSON parser
Other features and other fixes:
- [x] e2e testing of run workflow
- [x] #407
- [x] #410
- [x] #418
- [x] #424
- [x] #354
- [x] #409
- [x] #425
- [x] #426
- [x] #429
- [x] #433
- [x] #435
- [x] #421
- [x] #436
- [x] #437
- [x] #444
- [x] #438
- [x] #390
- [x] #451
- [x] #456
---------
Signed-off-by: Brian Ginsburg <7957636+bgins@users.noreply.github.com>
Signed-off-by: Zeeshan Lakhani <zeeshan.lakhani@gmail.com>
Co-authored-by: Brian Ginsburg <7957636+bgins@users.noreply.github.com>
Co-authored-by: Hugo Dias <hugomrdias@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: remove unnecessary decode of already utf8-ed string from wasmval.