Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: comments, logs, & cleanup #456

Merged
merged 31 commits into from
Nov 29, 2023
Merged

chore: comments, logs, & cleanup #456

merged 31 commits into from
Nov 29, 2023

Conversation

zeeshanlakhani
Copy link
Contributor

@zeeshanlakhani zeeshanlakhani commented Nov 29, 2023 •
edited
Loading

Description

Remove many TODOs, add comments on pub (pub crate), and work through logs.

  • Includes a few other minor fixins and additions.

Type of change

  • Refactor (non-breaking change that updates existing functionality)

Closes #262.

@zeeshanlakhani zeeshanlakhani requested a review from a team as a code owner November 29, 2023 05:51
bgins
bgins approved these changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@bgins bgins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Suggested a bunch of micro-changes, but this is overall a nice cleanup! ✨

DEVELOPMENT.md Outdated Show resolved Hide resolved
DEVELOPMENT.md Outdated Show resolved Hide resolved
DEVELOPMENT.md Outdated Show resolved Hide resolved
homestar-runtime/src/event_handler.rs Outdated Show resolved Hide resolved
homestar-runtime/src/event_handler.rs Outdated Show resolved Hide resolved
homestar-runtime/src/network/webserver.rs Outdated Show resolved Hide resolved
homestar-runtime/src/network/webserver/rpc.rs Outdated Show resolved Hide resolved
homestar-runtime/src/network/webserver/rpc.rs Outdated Show resolved Hide resolved
homestar-runtime/src/worker.rs Outdated Show resolved Hide resolved
homestar-runtime/src/worker.rs Outdated Show resolved Hide resolved
Zeeshan Lakhani and others added 25 commits November 29, 2023 13:32
@bgins
spelling: dev.md
c811ea8 
Co-authored-by: Brian Ginsburg <7957636+bgins@users.noreply.github.com>
Signed-off-by: Zeeshan Lakhani <zeeshan.lakhani@gmail.com>
@bgins
Update DEVELOPMENT.md
193f909 
Co-authored-by: Brian Ginsburg <7957636+bgins@users.noreply.github.com>
Signed-off-by: Zeeshan Lakhani <zeeshan.lakhani@gmail.com>
@bgins
Update DEVELOPMENT.md
0684639 
Co-authored-by: Brian Ginsburg <7957636+bgins@users.noreply.github.com>
Signed-off-by: Zeeshan Lakhani <zeeshan.lakhani@gmail.com>
@bgins
spelling: derp
d144548 
Co-authored-by: Brian Ginsburg <7957636+bgins@users.noreply.github.com>
Signed-off-by: Zeeshan Lakhani <zeeshan.lakhani@gmail.com>
@bgins
Update homestar-runtime/src/event_handler.rs
98f36a8 
Co-authored-by: Brian Ginsburg <7957636+bgins@users.noreply.github.com>
Signed-off-by: Zeeshan Lakhani <zeeshan.lakhani@gmail.com>
@bgins
Update homestar-runtime/src/network/webserver.rs
81ebd84 
Co-authored-by: Brian Ginsburg <7957636+bgins@users.noreply.github.com>
Signed-off-by: Zeeshan Lakhani <zeeshan.lakhani@gmail.com>
@bgins
Update homestar-runtime/src/network/webserver/rpc.rs
2262eb8 
Co-authored-by: Brian Ginsburg <7957636+bgins@users.noreply.github.com>
Signed-off-by: Zeeshan Lakhani <zeeshan.lakhani@gmail.com>
@bgins
Update homestar-runtime/src/network/webserver/rpc.rs
d16209d 
Co-authored-by: Brian Ginsburg <7957636+bgins@users.noreply.github.com>
Signed-off-by: Zeeshan Lakhani <zeeshan.lakhani@gmail.com>
@bgins
Update homestar-runtime/src/worker.rs
755fbe1 
.err

Co-authored-by: Brian Ginsburg <7957636+bgins@users.noreply.github.com>
Signed-off-by: Zeeshan Lakhani <zeeshan.lakhani@gmail.com>
@bgins
Update homestar-runtime/src/worker.rs
08a302d 
add .err

Co-authored-by: Brian Ginsburg <7957636+bgins@users.noreply.github.com>
Signed-off-by: Zeeshan Lakhani <zeeshan.lakhani@gmail.com>
@bgins
Update homestar-runtime/src/event_handler.rs
8c0d5b6 
Co-authored-by: Brian Ginsburg <7957636+bgins@users.noreply.github.com>
Signed-off-by: Zeeshan Lakhani <zeeshan.lakhani@gmail.com>
@bgins
Update homestar-runtime/src/event_handler.rs
ffcc4ec 
Co-authored-by: Brian Ginsburg <7957636+bgins@users.noreply.github.com>
Signed-off-by: Zeeshan Lakhani <zeeshan.lakhani@gmail.com>
@bgins
Update homestar-runtime/src/event_handler/swarm_event.rs
6a75b15 
Co-authored-by: Brian Ginsburg <7957636+bgins@users.noreply.github.com>
Signed-off-by: Zeeshan Lakhani <zeeshan.lakhani@gmail.com>
@bgins
Update homestar-runtime/src/event_handler.rs
8a6fd3b 
Co-authored-by: Brian Ginsburg <7957636+bgins@users.noreply.github.com>
Signed-off-by: Zeeshan Lakhani <zeeshan.lakhani@gmail.com>
@bgins
Update homestar-runtime/src/event_handler.rs
7ece92f 
Co-authored-by: Brian Ginsburg <7957636+bgins@users.noreply.github.com>
Signed-off-by: Zeeshan Lakhani <zeeshan.lakhani@gmail.com>
@bgins
Update homestar-runtime/src/event_handler.rs
9449c16 
Co-authored-by: Brian Ginsburg <7957636+bgins@users.noreply.github.com>
Signed-off-by: Zeeshan Lakhani <zeeshan.lakhani@gmail.com>
@bgins
Update homestar-runtime/src/event_handler/swarm_event.rs
6f4ba3e 
Co-authored-by: Brian Ginsburg <7957636+bgins@users.noreply.github.com>
Signed-off-by: Zeeshan Lakhani <zeeshan.lakhani@gmail.com>
@bgins
Update homestar-runtime/src/event_handler.rs
93e5e24 
Co-authored-by: Brian Ginsburg <7957636+bgins@users.noreply.github.com>
Signed-off-by: Zeeshan Lakhani <zeeshan.lakhani@gmail.com>
@bgins
Update homestar-runtime/src/event_handler/event.rs
2045946 
Co-authored-by: Brian Ginsburg <7957636+bgins@users.noreply.github.com>
Signed-off-by: Zeeshan Lakhani <zeeshan.lakhani@gmail.com>
@bgins
Update homestar-runtime/src/event_handler/swarm_event.rs
c13a850 
Co-authored-by: Brian Ginsburg <7957636+bgins@users.noreply.github.com>
Signed-off-by: Zeeshan Lakhani <zeeshan.lakhani@gmail.com>
@bgins
Update homestar-runtime/src/event_handler/swarm_event.rs
60a0525 
Co-authored-by: Brian Ginsburg <7957636+bgins@users.noreply.github.com>
Signed-off-by: Zeeshan Lakhani <zeeshan.lakhani@gmail.com>
@bgins
Update homestar-runtime/src/event_handler/swarm_event.rs
2dce259 
Co-authored-by: Brian Ginsburg <7957636+bgins@users.noreply.github.com>
Signed-off-by: Zeeshan Lakhani <zeeshan.lakhani@gmail.com>
@bgins
Update homestar-runtime/src/event_handler/swarm_event.rs
0e7f51e 
Co-authored-by: Brian Ginsburg <7957636+bgins@users.noreply.github.com>
Signed-off-by: Zeeshan Lakhani <zeeshan.lakhani@gmail.com>
@bgins
Update homestar-runtime/src/event_handler/swarm_event.rs
0f8b201 
Co-authored-by: Brian Ginsburg <7957636+bgins@users.noreply.github.com>
Signed-off-by: Zeeshan Lakhani <zeeshan.lakhani@gmail.com>
@bgins
Update homestar-runtime/src/event_handler/swarm_event.rs
618f79e 
Co-authored-by: Brian Ginsburg <7957636+bgins@users.noreply.github.com>
Signed-off-by: Zeeshan Lakhani <zeeshan.lakhani@gmail.com>
Zeeshan Lakhani and others added 4 commits November 29, 2023 13:42
@bgins
Update homestar-runtime/src/event_handler/swarm_event.rs
b3d8abf 
Co-authored-by: Brian Ginsburg <7957636+bgins@users.noreply.github.com>
Signed-off-by: Zeeshan Lakhani <zeeshan.lakhani@gmail.com>
@bgins
Update homestar-runtime/src/event_handler/swarm_event.rs
325ad10 
Co-authored-by: Brian Ginsburg <7957636+bgins@users.noreply.github.com>
Signed-off-by: Zeeshan Lakhani <zeeshan.lakhani@gmail.com>
@bgins
Update homestar-runtime/src/network/swarm.rs
569bbd7 
Co-authored-by: Brian Ginsburg <7957636+bgins@users.noreply.github.com>
Signed-off-by: Zeeshan Lakhani <zeeshan.lakhani@gmail.com>
@zeeshanlakhani
chore: address comments
b6a3db3
@zeeshanlakhani zeeshanlakhani merged commit 480311a into zl/jsonrpc Nov 29, 2023
23 checks passed
@zeeshanlakhani zeeshanlakhani deleted the zl/comments+logs branch November 29, 2023 20:34
zeeshanlakhani pushed a commit that referenced this pull request Nov 29, 2023
@bgins @zeeshanlakhani
chore: comments, logs, & cleanup (#456)
f794950 
# Description

Remove many TODOs, add comments on *pub* (*pub* crate), and work through
logs.

- Includes a few other minor fixins and additions. 

## Type of change

- [X] Refactor (non-breaking change that updates existing functionality)

Closes #262.

---------

Signed-off-by: Zeeshan Lakhani <zeeshan.lakhani@gmail.com>
Co-authored-by: Brian Ginsburg <7957636+bgins@users.noreply.github.com>
@bgins bgins mentioned this pull request Nov 29, 2023
Merged
20 tasks
bgins added a commit that referenced this pull request Nov 29, 2023
@bgins @hugomrdias
jsonrpc-feature returned (#417)
ac9167c 
## Description

Includes:
  - re-purposing of feature flags 
    * metrics is always a thing (on) 
    * monitoring is the gated feature 
    * The websocket-server flag is gone, we only gate push notifications
  - JSON-RPC setup and RPC method register
  - Prometheus exposition format to JSON parser

Other features and other fixes:

- [x] e2e testing of run workflow
- [x] #407
- [x] #410
- [x] #418
- [x] #424
- [x] #354 
- [x] #409
- [x] #425 
- [x] #426
- [x] #429 
- [x] #433
- [x] #435
- [x] #421
- [x] #436
- [x] #437
- [x] #444
- [x] #438
- [x] #390
- [x] #451 
- [x] #456

---------

Signed-off-by: Brian Ginsburg <7957636+bgins@users.noreply.github.com>
Signed-off-by: Zeeshan Lakhani <zeeshan.lakhani@gmail.com>
Co-authored-by: Brian Ginsburg <7957636+bgins@users.noreply.github.com>
Co-authored-by: Hugo Dias <hugomrdias@gmail.com>
bgins added a commit that referenced this pull request Nov 29, 2023
@bgins @hugomrdias
feat: Add JSON-PRC API (#417)
9b67136 
Includes:
  - re-purposing of feature flags
    * metrics is always a thing (on)
    * monitoring is the gated feature
    * The websocket-server flag is gone, we only gate push notifications
  - JSON-RPC setup and RPC method register
  - Prometheus exposition format to JSON parser

Other features and other fixes:

- [x] e2e testing of run workflow
- [x] #407
- [x] #410
- [x] #418
- [x] #424
- [x] #354
- [x] #409
- [x] #425
- [x] #426
- [x] #429
- [x] #433
- [x] #435
- [x] #421
- [x] #436
- [x] #437
- [x] #444
- [x] #438
- [x] #390
- [x] #451
- [x] #456

---------

Signed-off-by: Brian Ginsburg <7957636+bgins@users.noreply.github.com>
Signed-off-by: Zeeshan Lakhani <zeeshan.lakhani@gmail.com>
Co-authored-by: Brian Ginsburg <7957636+bgins@users.noreply.github.com>
Co-authored-by: Hugo Dias <hugomrdias@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bgins bgins bgins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zeeshanlakhani @bgins