Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support DNS multiaddr #545

Closed
walkah opened this issue Jan 30, 2024 · 0 comments · Fixed by #547
Closed

Support DNS multiaddr #545

walkah opened this issue Jan 30, 2024 · 0 comments · Fixed by #547
Assignees
@zeeshanlakhani
Labels
enhancement New feature or request networking Features, functionality involving networking

Comments

@walkah
Copy link
Contributor

walkah commented Jan 30, 2024 •
edited by zeeshanlakhani

Summary

It would be nice to support /dns* multiaddrs for specifying peers.

Problem

Right now, homestar peer addresses must be specified using /ip*, e.g. /ip4/192.168.2.16/...

Impact

This means that we can't use DNS to refer to hosted homestar nodes, e.g. /dns4/homestar.cloud.provider/...

Solution
@zeeshanlakhani zeeshanlakhani added enhancement New feature or request networking Features, functionality involving networking labels Jan 30, 2024
@zeeshanlakhani zeeshanlakhani self-assigned this Jan 30, 2024
@zeeshanlakhani zeeshanlakhani mentioned this issue Feb 5, 2024
Merged
zeeshanlakhani pushed a commit that referenced this issue Feb 5, 2024
@bgins
fix: add handling of dns multiaddrs + bootstrapping + CLI / Conn chan…
e0bb469 
…ges (#547)

fix: add handling of dns multiaddrs and added kad bootstrapping

Closes #545.
Closes #492. 

refactor: transport handling for ws & quic as fallback

Includes:
- dns fallback to cloudflare
- CLI: removal of -w for running workflows; it's now a positional
argument (the first one on run)
  * related to #489
- CLI: `node` command which showcases nodeinfo, e.g. peer_id and
listener addrs/connections
  * related to #489
- CLI: adds static/non-RPC `info` command showcasing version,
build-git-sha, and features built with. We can extend this later with
more build information.
- Closes #297
- Closes #497

---------

Signed-off-by: Zeeshan Lakhani <zeeshan.lakhani@gmail.com>
Co-authored-by: Brian Ginsburg <7957636+bgins@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zeeshanlakhani zeeshanlakhani

Labels
enhancement New feature or request networking Features, functionality involving networking
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: add handling of dns multiaddrs + bootstrapping + CLI / Conn changes ipvm-wg/homestar
2 participants
@walkah @zeeshanlakhani