Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed deadcode for context #355

Merged
merged 1 commit into from Oct 5, 2018
Merged

Conversation

AhmedRedaAmin
Copy link
Contributor

I have removed the deadcode requested in issue #349 , I haven't run the tests again , so ping me if that is needed , "I suppose you have an automated testing setup"

@Carreau
Copy link
Member

Carreau commented Oct 5, 2018

Thanks,

the test are run by Travis-CI and all of them are passing.

Merging ! Good job !

@Carreau Carreau merged commit 6900503 into ipython:master Oct 5, 2018
@Carreau Carreau mentioned this pull request Oct 5, 2018
@minrk minrk added this to the 5.1 milestone Oct 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants