Further cleanup on shutdown #419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avoids attempting to use io sockets after they are used, e.g. by sys.excepthook
- signal exit by calling threadsafe context.term from the main thread - catch resulting ETERM in heartbeat thread and close the socket cleanly - suppress ENOTSOCK caused by closing the socket elsewhere (shouldn't be done, but better to catch it than hang)
This was referenced Aug 7, 2019
|
Thanks you @minrk ! |
Closed
|
Way to go @minrk. Thanks! And @blink1073 for the review too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents errors if print, excepthook, etc. are called during shutdown, which were happening because we didn't...
cf #412 and jupyter/nbconvert#1052