Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only generate kernelspec when installing or building wheel #425

Merged
merged 1 commit into from
Aug 30, 2019
Merged

Only generate kernelspec when installing or building wheel #425

merged 1 commit into from
Aug 30, 2019

Conversation

SylvainCorlay
Copy link
Member

This slightly changes the kernelspec generation so that it only occurs

  • upon installation from source (with the full sys.executable)
  • or upon wheel generation (with 'python' as executable name)

blink1073
blink1073 approved these changes Aug 28, 2019
View reviewed changes
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@SylvainCorlay SylvainCorlay merged commit 7301869 into ipython:master Aug 30, 2019
@SylvainCorlay SylvainCorlay deleted the kernelspec-gen branch August 30, 2019 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blink1073 blink1073 blink1073 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SylvainCorlay @blink1073