ensure control stream is flushed before processing shell messages #443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
previous flush was not handled at the right time with new async dispatch Affected case: - shell request 1 takes a long time to process, is blocking (no async) - shell request 2 arrives - control request arrives later, but before shell request 1 is processed It's possible that shell request 2 is in our Python queue, but control request is still waiting one ioloop iteration to be handled from zmq.
|
@blink1073 Since this is causing failures in IPython parallel, I'd be happy to see this in 5.1.3 (#434), but I'm also okay if that ship has sailed. |
This was referenced Sep 27, 2019
blink1073
approved these changes
Sep 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
previous flush was not handled at the right time with new async dispatch to ensure control stream priority
Affected case:
awaitsIt's possible that shell request 2 is in our Python queue, but control request is still waiting one ioloop iteration
to be handled from zmq, and we want to make sure that we still process the control message first.
This is causing test failures in IPython parallel because task abort relies on proper queue priority handling.