-
-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove most of the python 2 compat code #537
Remove most of the python 2 compat code #537
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks! We picked up a few merge conflicts from #538, mind doing a rebase?
only because the encoding set was utf-8 and utf-8 is the default encoding on python 3
e.g. unittest.mock vs mock and queue vs Queue.
and update docstring in a similar one nearby
modified: ipykernel/iostream.py
modified: ipykernel/displayhook.py modified: ipykernel/ipkernel.py
@blink1073 i think I rebased correctly and didn't mess anything up. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thank you!
Note to reviewer : I have tried making one and only one type of change in each of the commits so reviewing this PR commit-by-commit will be straightforward.
This PR removes most of the machinery in the codebase that supported python 2/3 compatibility.
__future__
import statementsfunc.__closure__
instead of py3compat.get_closure(func)