Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fix stop_on_error_timeout blocking other messages in queue" #570

Merged
merged 1 commit into from
Dec 11, 2020

Conversation

afshin
Copy link
Member

@afshin afshin commented Dec 11, 2020

Running git bisect and pytest papermill/tests/test_execute.py::TestBrokenNotebook1::test showed that the error in #568 comes from #539. The message returned from kernel_info_request has status aborted. We are reverting the change to prevent downstream breakage. cc @glentakahashi we can revisit your changes in a follow up if you like, making sure that we better understand its ramifications.

self = <papermill.clientwrap.PapermillNotebookClient object at 0x7fc060ea5b20>, kwargs = {}
info_msg = {'buffers': [], 'content': {'status': 'aborted'}, 'header': {'date': datetime.datetime(2020, 12, 11, 20, 27, 58, 67808...bc689097e1e214f38609b', ...}, 'metadata': {'engine': '0d33e2cb-93c6-4480-983f-70f97a54b86d', 'status': 'aborted'}, ...}

Reverts #539

Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@glentakahashi
Copy link
Contributor

Sounds good, sorry that caused issues! Filed #571 to identify the correct follow up

@blink1073
Copy link
Contributor

No worries, thanks for posting the follow up!

@SylvainCorlay SylvainCorlay deleted the revert-539-master branch February 24, 2021 09:04
@Carreau Carreau added this to the 5.4 milestone Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants