fix names of notebooks for download/save #2365

Merged
merged 1 commit into from Aug 31, 2012

Conversation

Projects
None yet
3 participants
Owner

minrk commented Aug 30, 2012

was using notebook.get('name') instead of notebook.metadata.get('name'),
where the name is actually stored. The result was that all downloaded notebooks were called 'notebook'.

closes #2227

fix names of notebooks for download/save
was using notebook.get('name') instead of notebook.metadata.get('name'),
where the name is actually stored.  The result was that all downloaded notebooks were called 'notebook'.

closes #2227

This pull request passes (merged 02bebd7 into ddde2e1).

Owner

fperez commented Aug 31, 2012

no brainer, thanks! Merging now so we can make progress on 0.13.1 as per your post to the list.

fperez added a commit that referenced this pull request Aug 31, 2012

Merge pull request #2365 from minrk/nbname
fix names of notebooks for download/save from the browser, so that instead of being called 'notebook' the resulting file has the actual notebook name.

closes #2227

@fperez fperez merged commit eb8ae02 into ipython:master Aug 31, 2012

minrk added a commit that referenced this pull request Sep 1, 2012

Backport PR #2365: fix names of notebooks for download/save
was using notebook.get('name') instead of notebook.metadata.get('name'),
where the name is actually stored.  The result was that all downloaded notebooks were called 'notebook'.

closes #2227

@minrk minrk deleted the minrk:nbname branch Mar 31, 2014

yarikoptic added a commit to yarikoptic/ipython that referenced this pull request May 2, 2014

Merge tag 'rel-0.13.1' into debian-01X
* tag 'rel-0.13.1': (27 commits)
  remove rc for 0.13.1 final
  0.13.1.rc3
  qtconsole extras_require to whatsnew
  Backport PR #2492: add missing 'qtconsole' extras_require
  add 2480 to whatsnew
  Backport PR #2480: Add deprecation warnings for sympyprinting
  PR 2384 to whatsnew
  mark 0.13.1.rc2
  Backport PR #2384: Adapt inline backend to changes in matplotlib
  mark 0.13.1.rc1
  update 0.13.1 whatsnew lists
  Backport PR #2479: use new _winapi instead of removed _subprocess
  Backport PR #2437: don't let log cleanup prevent engine start
  Backport PR #2405: clarify TaskScheduler.hwm doc
  Backport PR #2377: Fix installation of man pages in Python 3
  start 0.13.1 whatsnew
  Backport PR #2373: fix missing imports in core.interactiveshell
  Backport PR #2365: fix names of notebooks for download/save
  Backport PR #2345: Remove references to 'version' no longer in argparse. Github issue #2343.
  Backport PR #2347: adjust division error message checking to account for Python 3
  ...

yarikoptic added a commit to yarikoptic/ipython that referenced this pull request May 2, 2014

Merge tag 'rel-0.13.1' (mtheirs) into releases
* tag 'rel-0.13.1': (51 commits)
  remove rc for 0.13.1 final
  0.13.1.rc3
  qtconsole extras_require to whatsnew
  Backport PR #2492: add missing 'qtconsole' extras_require
  add 2480 to whatsnew
  Backport PR #2480: Add deprecation warnings for sympyprinting
  PR 2384 to whatsnew
  mark 0.13.1.rc2
  Backport PR #2384: Adapt inline backend to changes in matplotlib
  mark 0.13.1.rc1
  update 0.13.1 whatsnew lists
  Backport PR #2479: use new _winapi instead of removed _subprocess
  Backport PR #2437: don't let log cleanup prevent engine start
  Backport PR #2405: clarify TaskScheduler.hwm doc
  Backport PR #2377: Fix installation of man pages in Python 3
  start 0.13.1 whatsnew
  Backport PR #2373: fix missing imports in core.interactiveshell
  Backport PR #2365: fix names of notebooks for download/save
  Backport PR #2345: Remove references to 'version' no longer in argparse. Github issue #2343.
  Backport PR #2347: adjust division error message checking to account for Python 3
  ...

mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this pull request Nov 3, 2014

Merge pull request #2365 from minrk/nbname
fix names of notebooks for download/save from the browser, so that instead of being called 'notebook' the resulting file has the actual notebook name.

closes #2227
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment