Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't let log cleanup prevent engine start #2437

Merged
merged 1 commit into from
Sep 28, 2012
Merged

Conversation

minrk
Copy link
Member

@minrk minrk commented Sep 27, 2012

closes #2435

@minrk
Copy link
Member Author

minrk commented Sep 28, 2012

confirmed as fixing the issue in #2435, merging.

minrk added a commit that referenced this pull request Sep 28, 2012
don't let log cleanup prevent engine start

simply suppresses errors during cleanup, since they shouldn't halt engine startup.
@minrk minrk merged commit ca10c42 into ipython:master Sep 28, 2012
minrk added a commit that referenced this pull request Oct 11, 2012
mindw pushed a commit to mindw/ipython that referenced this pull request Oct 18, 2012
@minrk minrk deleted the cleanlogs branch March 31, 2014 23:36
yarikoptic added a commit to yarikoptic/ipython that referenced this pull request May 2, 2014
* tag 'rel-0.13.1': (27 commits)
  remove rc for 0.13.1 final
  0.13.1.rc3
  qtconsole extras_require to whatsnew
  Backport PR ipython#2492: add missing 'qtconsole' extras_require
  add 2480 to whatsnew
  Backport PR ipython#2480: Add deprecation warnings for sympyprinting
  PR 2384 to whatsnew
  mark 0.13.1.rc2
  Backport PR ipython#2384: Adapt inline backend to changes in matplotlib
  mark 0.13.1.rc1
  update 0.13.1 whatsnew lists
  Backport PR ipython#2479: use new _winapi instead of removed _subprocess
  Backport PR ipython#2437: don't let log cleanup prevent engine start
  Backport PR ipython#2405: clarify TaskScheduler.hwm doc
  Backport PR ipython#2377: Fix installation of man pages in Python 3
  start 0.13.1 whatsnew
  Backport PR ipython#2373: fix missing imports in core.interactiveshell
  Backport PR ipython#2365: fix names of notebooks for download/save
  Backport PR ipython#2345: Remove references to 'version' no longer in argparse. Github issue ipython#2343.
  Backport PR ipython#2347: adjust division error message checking to account for Python 3
  ...
yarikoptic added a commit to yarikoptic/ipython that referenced this pull request May 2, 2014
* tag 'rel-0.13.1': (51 commits)
  remove rc for 0.13.1 final
  0.13.1.rc3
  qtconsole extras_require to whatsnew
  Backport PR ipython#2492: add missing 'qtconsole' extras_require
  add 2480 to whatsnew
  Backport PR ipython#2480: Add deprecation warnings for sympyprinting
  PR 2384 to whatsnew
  mark 0.13.1.rc2
  Backport PR ipython#2384: Adapt inline backend to changes in matplotlib
  mark 0.13.1.rc1
  update 0.13.1 whatsnew lists
  Backport PR ipython#2479: use new _winapi instead of removed _subprocess
  Backport PR ipython#2437: don't let log cleanup prevent engine start
  Backport PR ipython#2405: clarify TaskScheduler.hwm doc
  Backport PR ipython#2377: Fix installation of man pages in Python 3
  start 0.13.1 whatsnew
  Backport PR ipython#2373: fix missing imports in core.interactiveshell
  Backport PR ipython#2365: fix names of notebooks for download/save
  Backport PR ipython#2345: Remove references to 'version' no longer in argparse. Github issue ipython#2343.
  Backport PR ipython#2347: adjust division error message checking to account for Python 3
  ...
mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this pull request Nov 3, 2014
don't let log cleanup prevent engine start

simply suppresses errors during cleanup, since they shouldn't halt engine startup.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ipengines fail if clean_logs enabled
1 participant