Fix installation of man pages in Python 3 #2377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
It might be neater to use a list comprehension, rather than |
|
@takluyver - good idea, I'll do that |
|
Done - how does this look? |
|
That looks good, but the comment you added is now a bit mysterious. ;-) Now, can we work out what causes the man pages not to be installed? And ideally they should be installed as |
…running from the source tree.
|
@takluyver - thanks for pointing out the issue with the comment. I fixed this and rebased to avoid having 5 commits for such a small change. Regarding the installation location of the man pages, it seems from #2374 that this is expected behavior, so maybe this PR can now be merged? |
bfroehle
added a commit
that referenced
this pull request
Sep 18, 2012
Fix installation of man pages in Python 3
|
@astrofrog Thanks for rebasing/squashing the commits. I've merged the pull request. |
|
@minrk I've also tagged this for backport to 0.13.1. |
minrk
added a commit
that referenced
this pull request
Oct 11, 2012
This fixes a bug that caused man pages to not be installed in Python 3 when running from the source tree. The issue was that in Python 3, an empty filter is not an empty list, so ``if not manpages`` could not be satisfied. By using ``list()``, we can ensure that we convert the filter iterator to a list in Python 3. This partially fixes #2374.
mindw
pushed a commit
to mindw/ipython
that referenced
this pull request
Oct 18, 2012
This fixes a bug that caused man pages to not be installed in Python 3 when running from the source tree. The issue was that in Python 3, an empty filter is not an empty list, so ``if not manpages`` could not be satisfied. By using ``list()``, we can ensure that we convert the filter iterator to a list in Python 3. This partially fixes ipython#2374.
yarikoptic
added a commit
to yarikoptic/ipython
that referenced
this pull request
May 2, 2014
* tag 'rel-0.13.1': (27 commits) remove rc for 0.13.1 final 0.13.1.rc3 qtconsole extras_require to whatsnew Backport PR ipython#2492: add missing 'qtconsole' extras_require add 2480 to whatsnew Backport PR ipython#2480: Add deprecation warnings for sympyprinting PR 2384 to whatsnew mark 0.13.1.rc2 Backport PR ipython#2384: Adapt inline backend to changes in matplotlib mark 0.13.1.rc1 update 0.13.1 whatsnew lists Backport PR ipython#2479: use new _winapi instead of removed _subprocess Backport PR ipython#2437: don't let log cleanup prevent engine start Backport PR ipython#2405: clarify TaskScheduler.hwm doc Backport PR ipython#2377: Fix installation of man pages in Python 3 start 0.13.1 whatsnew Backport PR ipython#2373: fix missing imports in core.interactiveshell Backport PR ipython#2365: fix names of notebooks for download/save Backport PR ipython#2345: Remove references to 'version' no longer in argparse. Github issue ipython#2343. Backport PR ipython#2347: adjust division error message checking to account for Python 3 ...
yarikoptic
added a commit
to yarikoptic/ipython
that referenced
this pull request
May 2, 2014
* tag 'rel-0.13.1': (51 commits) remove rc for 0.13.1 final 0.13.1.rc3 qtconsole extras_require to whatsnew Backport PR ipython#2492: add missing 'qtconsole' extras_require add 2480 to whatsnew Backport PR ipython#2480: Add deprecation warnings for sympyprinting PR 2384 to whatsnew mark 0.13.1.rc2 Backport PR ipython#2384: Adapt inline backend to changes in matplotlib mark 0.13.1.rc1 update 0.13.1 whatsnew lists Backport PR ipython#2479: use new _winapi instead of removed _subprocess Backport PR ipython#2437: don't let log cleanup prevent engine start Backport PR ipython#2405: clarify TaskScheduler.hwm doc Backport PR ipython#2377: Fix installation of man pages in Python 3 start 0.13.1 whatsnew Backport PR ipython#2373: fix missing imports in core.interactiveshell Backport PR ipython#2365: fix names of notebooks for download/save Backport PR ipython#2345: Remove references to 'version' no longer in argparse. Github issue ipython#2343. Backport PR ipython#2347: adjust division error message checking to account for Python 3 ...
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
Fix installation of man pages in Python 3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug that caused man pages to not be installed in Python 3 when running from the source tree. The issue was that in Python 3, an empty filter is not an empty list, so
if not manpagescould not be satisfied. By usinglist(), we can ensure that we convert the filter iterator to a list in Python 3. This partially fixes #2374.