use new _winapi instead of removed _subprocess #2479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`_subprocess` is removed in Python 3.3, and the relevant names relocated to a new `_winapi` module. ref: http://bugs.python.org/issue11750 closes ipython#2471 should be back ported to 0.13.1
|
Looks good to me, but I don't have access to a windows box to test. |
|
Took a bit of fiddling to update things on my Windows VM (needed VC++ 2010 to build pyzmq for py3.3), but I can confirm that the notebook works on Python 3.3 on Windows with this fix (where it would fail with ImportErrors on master). |
bfroehle
added a commit
that referenced
this pull request
Oct 11, 2012
Use new _winapi instead of removed _subprocess New in Python 3.3, c.f. http://bugs.python.org/issue11750 Maintain existing support by falling back on _subprocess if _winapi cannot be imported.
|
Just committed this based upon your review. |
|
@minrk I'll let you add this to the 0.13 branch. |
minrk
added a commit
that referenced
this pull request
Oct 11, 2012
`_subprocess` is removed in Python 3.3, and the relevant names relocated to a new `_winapi` module. closes #2471 should be back ported to 0.13.1 because all zmq-based IPython will fail on win/py3.3 without it. ref: http://bugs.python.org/issue11750
mindw
pushed a commit
to mindw/ipython
that referenced
this pull request
Oct 18, 2012
`_subprocess` is removed in Python 3.3, and the relevant names relocated to a new `_winapi` module. closes ipython#2471 should be back ported to 0.13.1 because all zmq-based IPython will fail on win/py3.3 without it. ref: http://bugs.python.org/issue11750
yarikoptic
added a commit
to yarikoptic/ipython
that referenced
this pull request
May 2, 2014
* tag 'rel-0.13.1': (27 commits) remove rc for 0.13.1 final 0.13.1.rc3 qtconsole extras_require to whatsnew Backport PR ipython#2492: add missing 'qtconsole' extras_require add 2480 to whatsnew Backport PR ipython#2480: Add deprecation warnings for sympyprinting PR 2384 to whatsnew mark 0.13.1.rc2 Backport PR ipython#2384: Adapt inline backend to changes in matplotlib mark 0.13.1.rc1 update 0.13.1 whatsnew lists Backport PR ipython#2479: use new _winapi instead of removed _subprocess Backport PR ipython#2437: don't let log cleanup prevent engine start Backport PR ipython#2405: clarify TaskScheduler.hwm doc Backport PR ipython#2377: Fix installation of man pages in Python 3 start 0.13.1 whatsnew Backport PR ipython#2373: fix missing imports in core.interactiveshell Backport PR ipython#2365: fix names of notebooks for download/save Backport PR ipython#2345: Remove references to 'version' no longer in argparse. Github issue ipython#2343. Backport PR ipython#2347: adjust division error message checking to account for Python 3 ...
yarikoptic
added a commit
to yarikoptic/ipython
that referenced
this pull request
May 2, 2014
* tag 'rel-0.13.1': (51 commits) remove rc for 0.13.1 final 0.13.1.rc3 qtconsole extras_require to whatsnew Backport PR ipython#2492: add missing 'qtconsole' extras_require add 2480 to whatsnew Backport PR ipython#2480: Add deprecation warnings for sympyprinting PR 2384 to whatsnew mark 0.13.1.rc2 Backport PR ipython#2384: Adapt inline backend to changes in matplotlib mark 0.13.1.rc1 update 0.13.1 whatsnew lists Backport PR ipython#2479: use new _winapi instead of removed _subprocess Backport PR ipython#2437: don't let log cleanup prevent engine start Backport PR ipython#2405: clarify TaskScheduler.hwm doc Backport PR ipython#2377: Fix installation of man pages in Python 3 start 0.13.1 whatsnew Backport PR ipython#2373: fix missing imports in core.interactiveshell Backport PR ipython#2365: fix names of notebooks for download/save Backport PR ipython#2345: Remove references to 'version' no longer in argparse. Github issue ipython#2343. Backport PR ipython#2347: adjust division error message checking to account for Python 3 ...
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
Use new _winapi instead of removed _subprocess New in Python 3.3, c.f. http://bugs.python.org/issue11750 Maintain existing support by falling back on _subprocess if _winapi cannot be imported.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_subprocessis removed in Python 3.3, and the relevant names relocated to a new_winapimodule.closes #2471
should be back ported to 0.13.1 because all zmq-based IPython will fail on win/py3.3 without it.
ref: http://bugs.python.org/issue11750