Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid modifications in dictionary during iteration #3

Merged
merged 2 commits into from
Apr 14, 2015

Conversation

SylvainCorlay
Copy link
Member

Calls to monkey-patched _notify_trait resulting from cross validation may cause the cache dictionary to be modified.

@minrk
Copy link
Member

minrk commented Apr 9, 2015

If this fixes a bug, can you add a test for the bug?

@SylvainCorlay
Copy link
Member Author

IntSlider(min=1) triggers the bug. I will add a test.

@SylvainCorlay
Copy link
Member Author

Added a test.

minrk added a commit that referenced this pull request Apr 14, 2015
Avoid modifications in dictionary during iteration

closes #5
@minrk minrk merged commit 86850a2 into ipython:master Apr 14, 2015
@minrk minrk added this to the 4.0 milestone Apr 14, 2015
@minrk minrk mentioned this pull request Apr 20, 2015
minrk added a commit that referenced this pull request Apr 20, 2015
Avoid modifications in dictionary during iteration

closes #5
@SylvainCorlay SylvainCorlay deleted the cache_keys branch June 5, 2015 03:15
azjps added a commit to azjps/traitlets that referenced this pull request Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants