Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable coredump generation #619

Closed
wants to merge 1 commit into from
Closed

Conversation

royhunter
Copy link
Contributor

Enable coredump generation via rlimit setting from code level

Copy link
Collaborator

@ywc689 ywc689 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's advised to make some improvements for this feature.

  1. Coredump feature needs to be enabled/disabled from user config files or command option.
  2. Coredump soft/hard resource limits should be set by users.

@ywc689 ywc689 added the pr/codes-need-change problems found in the line-by-line code review and need to be fixed label Jul 29, 2020
@andrewhit
Copy link

It's advised to make some improvements for this feature.

  1. Coredump feature needs to be enabled/disabled from user config files or command option.
  2. Coredump soft/hard resource limits should be set by users.

Even though the below configuration is added, it does not guarantee the coredump is determined to be generated. So this patch is provided.

root@n25-146-090:/# cat /etc/security/limits.conf
# /etc/security/limits.conf
...
root    soft    core    unlimited
root@n25-146-090:/# cat /etc/rc.local
#!/bin/sh -e
modprobe ipmi_devintf; modprobe ipmi_si
echo "/opt/tiger/cores/core.%e.%p.%h.%t" > /proc/sys/kernel/core_pattern
ulimit -c unlimited
exit 0

@ywc689
Copy link
Collaborator

ywc689 commented Aug 10, 2020

Coredump configured in "/etc/security/limits.conf" may be ignored if your DPVS is managed by a service manager, such as systemd. In this case, you should enable coredump by the service manager rather than the limits.conf file. Refer to https://zhuanlan.zhihu.com/p/41153588 as an example.

@ywc689
Copy link
Collaborator

ywc689 commented Jan 15, 2021

Coredump can be enabled/disabled by the means outside of DPVS. This patch is closing, and if any problem, please reopen it.

@ywc689 ywc689 closed this Jan 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/codes-need-change problems found in the line-by-line code review and need to be fixed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants