9507 show linked collections #9970
Conversation
sekmiller
added this to Ready for Review ⏩
in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
via automation
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
There were some typos (singular vs plural). That said, I wonder if we want to do the bundle changes here or not. I know they are eventually needed, but as this is not comprehensive I'd be worried that is more confusing. I would vote for saying that we can make the full change to use collection in the SPA. (also not sure if we've decided on collection vs Dataverse collection or if mixed when one or the other. Or have we?)
Also, how does this handle a case where it is linked to a large number of collections? does it wrap, is it readable, does it affect the size of the popup?
| dataverse.link.yourDataverses=Your Collection | ||
| dataverse.link.yourDataverses.inputPlaceholder=Enter Collection Name | ||
| dataverse.link.save=Save Linked collection | ||
| dataverse.link.dataverse.choose=Choose which of your collection you would like to link this collection to. |
| dataverse.link.dataverse.choose=Choose which of your collection you would like to link this collection to. | ||
| dataverse.link.dataset.choose=Enter the name of the collection you would like to link this dataset to. If you need to remove this link in the future, please contact {0}. | ||
| dataverse.link.dataset.none=No linkable collections available. | ||
| dataverse.link.no.choice=You have one collection you can add linked collection and datasets in. |
| dataverse.link.no.linkable.remaining=You have already linked all of your eligible dataverses. | ||
| dataverse.link=Link Collection | ||
| dataverse.link.btn.tip=Link to Your Collection | ||
| dataverse.link.yourDataverses=Your Collection |
There was a problem hiding this comment.
typo? (I noticed the before was also singular, so I'm not sure of the contect, but the key is plural)
There was a problem hiding this comment.
It was singular in the original. I'll take a look at it in context and maybe change the key name.
| dataverse.savedsearch.link=Link Search | ||
| dataverse.savedsearch.searchquery=Search | ||
| dataverse.savedsearch.filterQueries=Facets | ||
| dataverse.savedsearch.save=Save Linked Search | ||
| dataverse.savedsearch.dataverse.choose=Choose which of your dataverses you would like to link this search to. | ||
| dataverse.savedsearch.no.choice=You have one dataverse to which you may add a saved search. | ||
| dataverse.savedsearch.dataverse.choose=Choose which of your collection you would like to link this search to. |
This comment has been minimized.
This comment has been minimized.
|
expanded popup with wrapping... |
scolapasta
moved this from Ready for Review ⏩
to In Review 🔎
in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
|
Per discussion with Gusatvo and Julian, we will defer the updating of the bundle to refer to "collections" until it is done on an application-wide basis. |
with the reverted bundle |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
📦 Pushed preview images as 🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name. |
What this PR does / why we need it:
Lists by name the collections that a dataset is already linked to in the "Link Dataset" popup. It's needed because users have been confused by trying to link a dataset to a collection that it is already linked to. The popup "doesn't find" the collection that they type into the text box and there's no indication why this is happening. Hopefully this info note will alleviate the confusion and eliminate help tickets
Which issue(s) this PR closes:
Closes #9507 show the collections the dataset is already linked to in the UI
Special notes for your reviewer:
There are a bunch of changes to the bundle from "Dataverse" to collection (slightly off topic to include "saved search" and link Dataverse)
Suggestions on how to test this:
Once you link a dataset to a collection if you try to link it to another you should see the name of any linked collections in the link dataset pop up.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?: no
Additional documentation: none