Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

9507 show linked collections #9970

Merged
merged 14 commits into from
Oct 16, 2023
Merged

9507 show linked collections #9970

merged 14 commits into from
Oct 16, 2023

Conversation

sekmiller
Copy link
Contributor

What this PR does / why we need it:
Lists by name the collections that a dataset is already linked to in the "Link Dataset" popup. It's needed because users have been confused by trying to link a dataset to a collection that it is already linked to. The popup "doesn't find" the collection that they type into the text box and there's no indication why this is happening. Hopefully this info note will alleviate the confusion and eliminate help tickets

Which issue(s) this PR closes:

Closes #9507 show the collections the dataset is already linked to in the UI

Special notes for your reviewer:
There are a bunch of changes to the bundle from "Dataverse" to collection (slightly off topic to include "saved search" and link Dataverse)

Suggestions on how to test this:
Once you link a dataset to a collection if you try to link it to another you should see the name of any linked collections in the link dataset pop up.

Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Screen Shot 2023-10-02 at 4 35 30 PM

Is there a release notes update needed for this change?: no

Additional documentation: none

@sekmiller sekmiller added this to the 6.1 milestone Oct 3, 2023
@coveralls
Copy link

coveralls commented Oct 3, 2023

Coverage Status

coverage: 20.035% (-0.003%) from 20.038% when pulling 7eb213a on 9507-show-linked-collections into 7e0738e on develop.

@github-actions

This comment has been minimized.

1 similar comment
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

Copy link
Contributor

@scolapasta scolapasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There were some typos (singular vs plural). That said, I wonder if we want to do the bundle changes here or not. I know they are eventually needed, but as this is not comprehensive I'd be worried that is more confusing. I would vote for saying that we can make the full change to use collection in the SPA. (also not sure if we've decided on collection vs Dataverse collection or if mixed when one or the other. Or have we?)

Also, how does this handle a case where it is linked to a large number of collections? does it wrap, is it readable, does it affect the size of the popup?

dataverse.link.yourDataverses=Your Collection
dataverse.link.yourDataverses.inputPlaceholder=Enter Collection Name
dataverse.link.save=Save Linked collection
dataverse.link.dataverse.choose=Choose which of your collection you would like to link this collection to.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

dataverse.link.dataverse.choose=Choose which of your collection you would like to link this collection to.
dataverse.link.dataset.choose=Enter the name of the collection you would like to link this dataset to. If you need to remove this link in the future, please contact {0}.
dataverse.link.dataset.none=No linkable collections available.
dataverse.link.no.choice=You have one collection you can add linked collection and datasets in.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

dataverse.link.no.linkable.remaining=You have already linked all of your eligible dataverses.
dataverse.link=Link Collection
dataverse.link.btn.tip=Link to Your Collection
dataverse.link.yourDataverses=Your Collection
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo? (I noticed the before was also singular, so I'm not sure of the contect, but the key is plural)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was singular in the original. I'll take a look at it in context and maybe change the key name.

dataverse.savedsearch.link=Link Search
dataverse.savedsearch.searchquery=Search
dataverse.savedsearch.filterQueries=Facets
dataverse.savedsearch.save=Save Linked Search
dataverse.savedsearch.dataverse.choose=Choose which of your dataverses you would like to link this search to.
dataverse.savedsearch.no.choice=You have one dataverse to which you may add a saved search.
dataverse.savedsearch.dataverse.choose=Choose which of your collection you would like to link this search to.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

@github-actions

This comment has been minimized.

@sekmiller
Copy link
Contributor Author

Also, how does this handle a case where it is linked to a large number of collections? does it wrap, is it readable, does it affect the size of the popup?

  • the popup expands a bit then wraps in a readable way.

@sekmiller
Copy link
Contributor Author

Screen Shot 2023-10-11 at 10 00 22 AM

expanded popup with wrapping...

@github-actions

This comment has been minimized.

1 similar comment
@github-actions

This comment has been minimized.

@sekmiller sekmiller removed their assignment Oct 11, 2023
@sekmiller
Copy link
Contributor Author

Per discussion with Gusatvo and Julian, we will defer the updating of the bundle to refer to "collections" until it is done on an application-wide basis.

@sekmiller
Copy link
Contributor Author

Screen Shot 2023-10-11 at 11 24 59 AM

with the reverted bundle

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@kcondon kcondon self-assigned this Oct 16, 2023
@kcondon kcondon merged commit 2aa71fb into develop Oct 16, 2023
4 of 5 checks passed
@kcondon kcondon deleted the 9507-show-linked-collections branch October 16, 2023 15:43
@github-actions
Copy link

📦 Pushed preview images as

ghcr.io/gdcc/dataverse:9507-show-linked-collections
ghcr.io/gdcc/configbaker:9507-show-linked-collections

🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show the collection(s) the dataset is already linked to in the UI
4 participants