Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dx/add post compile hook #2

Merged
merged 6 commits into from
Aug 29, 2022
Merged

Dx/add post compile hook #2

merged 6 commits into from
Aug 29, 2022

Conversation

pvbergen
Copy link
Contributor

@pvbergen pvbergen commented Aug 25, 2022

This PR introduces updating of styling profiles css when the iq_scss_compiler is run.

Works only in conjunction with iqual-ch/iq_barrio_helper#10, iqual-ch/iq_barrio#22, iqual-ch/iq_scss_compiler#5.

Open tasks:

  • iq_stage_file_proxy is overriding compilation in local env
  • Testing
  • Review

@pvbergen
Copy link
Contributor Author

pvbergen commented Aug 25, 2022

Tested with GS1 locally:

  • Styling profile changes were saved in the correct definitions file within sites/files/[STYLING_PROFILE]/iq_barrio/resources/sass/_definitions.scss and sass files of iq_custom and iq_barrio were copied and compiled
  • Settings in /admin/appearance were correctly saved in themes/custom/iq_barrio/resources/sass/_definitions.scss
  • Files were copied and compiled with drush iqsc:compile

Any other test cases?

@pvbergen
Copy link
Contributor Author

pvbergen commented Aug 25, 2022

Adjusting iq_stage_file_proxy in https://github.com/iqual-ch/iq_stage_file_proxy/pull/4/files; Moving alter hook to iq_scss_compiler

@pvbergen pvbergen marked this pull request as ready for review August 29, 2022 09:38
@pvbergen pvbergen merged commit 7570ae1 into 2.x Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant