Setuptools conversion #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # This flag says that the code is written to work on both Python 2 and Python | ||
| # 3. If at all possible, it is good practice to do this. If you cannot, you | ||
| # will need to generate wheels for each Python version that you support. | ||
| universal=1 |
There was a problem hiding this comment.
This is not correct exactly. The code is written to work on Py2, and to work on Py3 after 2to3 is run (with no hand editing). Should we still have universal=1 set? I'm thinking not, but you know more about it.
|
Sorry Chris, I should have mentioned I wasn't done porting this package yet (it's a copy/paste/sed-replaced boilerplate at the moment). There are a lot of little details to flesh out with this one. |
|
If you still need this, need to rebase to resolve conflict. FYI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Help wanted.