Switch to TypeScript #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code is a bit messy right now, it needs to go through some refactoring.
Warning: There is a dependency issue with create-react-app's react-scripts. Both fork-ts-checker-webpack-plugin dependency and the "overrides" section in package.json should serve as a workaround.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code is a bit messy right now and tons of types are missing. A general refactoring would be great, adding to what was mentioned in #5.
There were some dependency issues with create-react-app, which could be bypassed using
fork-ts-checker-webpack-plugindependency and adding anoverridessection to the client's package.json. see facebook/create-react-app#13080. Moreover, the tool appears to be discontinued, with just a couple of commits in the last two years. It might make sense to migrate to a framework such as NextJS in the future, although I don't think it's urgent.