Add metadata-2 spec #501
Merged
Add metadata-2 spec #501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Like every other spec
|
|
Their first argument is the requesting client (like any numeric), followed by the target (their first own argument)
for consistency with other specs
…iple params It simplifies parsing, as it's tokenized by the main parser this way.
6 tasks
k4bek4be
added a commit
to pirc-pl/unrealircd-modules
that referenced
this pull request
Nov 19, 2023
|
When I'm joining a new channel (or receiving a join from a bouncer), I might want to wait until I've gathered all the information about a channel before displaying it. Right now I wait until RPL_ENDOFNAMES before considering the join complete and showing it. The current spec gives 2 examples: Is it guaranteed that I will receive either a metadata batch or an RPL_METADATASYNCLATER on join? In which case, can I wait on either of those before considering the entire join complete? Maybe that should be made clearer in the spec? (If it's a RPL_METADATASYNCLATER I'll probably give up waiting and show the channel immediately, then sync the contents later.) |
delthas
added a commit
to delthas/soju
that referenced
this pull request
Aug 27, 2024
First, this implements support for the metadata-2 specification, work-in-progress by progval on ircv3-specifications [1]. The METADATA implementation is bouncer-only (namely, it does not interact with any upstream METADATA). The implementation is specific in that there are only 2 supported keys: "pinned" and "muted". The user cannot set any other keys. Those keys can only be "0" or "1", representing a boolean. This enables downstreams to get/set two flags on each "message target" (which can be either users or channels): pinned and muted. - "pinned" is "1" when the channel should be pinned in the client, e.g. shown at the top of the channel list - "muted" is "1" when the channel should be muted, e.g. have its notifications on non-highlights hidden The actual specific client behavior for "pinned" and "muted" is not defined here. This just enabels clients to get/set the flags. [1]: ircv3/ircv3-specifications#501
|
Is this good to be merged as draft so we can encourage more implementation, and remove the confusing "deprecated" status metadata has on the website? |
This was referenced Sep 21, 2024
|
I think so, and it will make it easier to iterate with new PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As far as I am aware, it addresses all known issues with the current deprecated metadata spec (listed in #339).
It is based on @DanielOaks' latest version, which is itself based on #339. Notable changes since dan's version are:
metadata-2, since it is a breaking change compared to the deprecated specrendered