Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error of test's compilation #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

VasyaSmolyar
Copy link

Make returned errors of undeclared "aio_write", "aio_read" and "sigval_t" in 'linux-async-pipe.c'. And make RELEASE=1 didn't work without -lasan flag.

@@ -25,6 +27,10 @@ int async_pipe_read(async_pipe_t pipe, void* msg, int len, async_pipe_onread cal
// return: 0-success, other-error
int async_pipe_write(async_pipe_t pipe, const void* msg, int len, async_pipe_onwrite callback, void* param);

static void aio_onread(sigval_t sigval);

static void aio_onwrite(sigval_t sigval);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Declare static aio_onread/aio_onwrite ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, compiler didn't found this functions in linux-async-pipe.c without declaration in this include file. Maybe this functions can be declared in linux-async-pipe.c?

@@ -46,7 +46,7 @@ else
LIBPATHS +=
endif

LIBS = rt pthread dl aio
LIBS = rt pthread dl aio asan
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe i should delete -fsanitize=address option in gcc.mk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants