Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose VM extension support as compilation target configuration #2728

Open
benvanik opened this issue Jul 31, 2020 · 1 comment
Open

Expose VM extension support as compilation target configuration #2728

benvanik opened this issue Jul 31, 2020 · 1 comment
Assignees
@benvanik
Labels
compiler/dialects Relating to the IREE compiler dialects (flow, hal, vm) enhancement ➕ New feature or request help wanted Extra attention is needed

Comments

@benvanik
Copy link
Collaborator

With the IREE VM supporting i64 in #2574 it's possible to lower from various dialects while preserving the i64 type. Support in https://github.com/google/iree/blob/main/iree/compiler/Dialect/VM/Conversion/StandardToVM/ConvertStandardToVM.cpp will need to be improved for standard ops like std.add, but also we'll want to improve the automated VM ABI conversion in VMImportOpConversion to support these as well (assuming we want to support i64 across the ABI to custom modules).

Tests in StandardToVM showing std usage with 64-bit types will be a good start.
@benvanik benvanik added enhancement ➕ New feature or request help wanted Extra attention is needed compiler/dialects Relating to the IREE compiler dialects (flow, hal, vm) labels Jul 31, 2020
@benvanik benvanik mentioned this issue Jul 31, 2020
Closed
5 tasks
@benvanik
Copy link
Collaborator Author

benvanik commented Nov 22, 2020 •
edited
Loading

This requires configuration plumbing; related to #3817.

@benvanik benvanik changed the title Add support for i64 lowering into the VM Expose VM extension support as compilation target configuration Nov 22, 2020
@benvanik benvanik self-assigned this Nov 22, 2020
@GMNGeoffrey GMNGeoffrey added this to IREE Jun 28, 2022
@github-project-automation github-project-automation bot moved this to Not Started in (Deprecated) IREE Feb 21, 2023
@allieculp allieculp moved this from Not Started to Backlog in (Deprecated) IREE May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benvanik benvanik

Labels
compiler/dialects Relating to the IREE compiler dialects (flow, hal, vm) enhancement ➕ New feature or request help wanted Extra attention is needed
Projects
No open projects
IREE
Status: No status
Milestone
No milestone
Development

No branches or pull requests
1 participant
@benvanik