Disable Bit-width change for modules with external functions. #14114
Conversation
This patch will disable bit-width changes for modules that have external functions. Since the body of the function is compiled elsewhere and just linked, any modification will cause linker issues.
There was a problem hiding this comment.
This is too broad - the only thing that shouldn't be changed is the external function declarations and calls to those external functions. Disabling the entire pass should only be done with the command line flags for toggling the passes.
To do it at the appropriate scope you can gather all extern function declarations into a set and then in the FuncOp/CallOp patterns test if the target is in the set before bailing on that one particular pattern.
But really, if disabling the pass entirely works for you the best thing to do is just pass the compiler flags to disable the pass.
| // pattern match and does not have the full concept of control/data flow. | ||
| // Thus, doing it in finer-granularity causes type-mismatches. | ||
| this->getOperation().walk([&](mlir::CallOpInterface callOp) { | ||
| foundExternalFunc |= (callOp->getRegions().empty()); |
There was a problem hiding this comment.
callOp always have no regions, you need to find referenced FuncOp. Or just walk func::FuncOp ops.
|
Closing stale PR. |
This patch will disable bit-width changes for modules that have external functions. Since the body of the function is compiled elsewhere and just linked, any modification will cause linker issues.
Fixes: #12987