[CPU] Add support for converting math.powf from fp16 to fp32. #15927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a bug in polynomial approximation. It generates `NAN` and `INF` for fp16 types. This is a workaround to get it functional. Also rework on the maximumf test. The generic op is not a common input because it uses `outs` while there are no reduction loops.
rsuderman
approved these changes
Dec 14, 2023
ramiro050
pushed a commit
to ramiro050/iree
that referenced
this pull request
Dec 19, 2023
…rg#15927) There is a bug in polynomial approximation. It generates `NAN` and `INF` for fp16 types. This is a workaround to get it functional. See iree-org#15661 for more details. Also rework on the maximumf test. The generic op is not a common input because it uses `outs` while there are no reduction loops.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bug in polynomial approximation. It generates
NANandINFfor fp16 types. This is a workaround to get it functional. See #15661 for more details.Also rework on the maximumf test. The generic op is not a common input because it uses
outswhile there are no reduction loops.