[Im2col] Allow multiple batch, M, and K dimensions on im2col result #18593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Max191
force-pushed
the
expanded-im2col-op
branch
4 times, most recently
from
83997e3
to
3906d86
Compare
Max191
requested review from
hanhanW,
MaheshRavishankar,
qedawkins,
kuhar,
Groverkss and
antiagainst
as code owners
hanhanW
requested changes
Oct 2, 2024
compiler/src/iree/compiler/Dialect/LinalgExt/IR/test/roundtrip.mlir
Outdated
Show resolved
Hide resolved
compiler/src/iree/compiler/Dialect/LinalgExt/Transforms/AggregatedOpInterfaceImpl.cpp
Outdated
Show resolved
Hide resolved
compiler/src/iree/compiler/Dialect/LinalgExt/Transforms/AggregatedOpInterfaceImpl.cpp
Outdated
Show resolved
Hide resolved
compiler/src/iree/compiler/Dialect/LinalgExt/Transforms/AggregatedOpInterfaceImpl.cpp
Outdated
Show resolved
Hide resolved
compiler/src/iree/compiler/Dialect/LinalgExt/Transforms/AggregatedOpInterfaceImpl.cpp
Show resolved
Hide resolved
compiler/src/iree/compiler/Dialect/LinalgExt/Transforms/TilingInterfaceImpl.cpp
Outdated
Show resolved
Hide resolved
Max191
force-pushed
the
expanded-im2col-op
branch
from
3906d86
to
4d539e4
Compare
qedawkins
reviewed
Oct 8, 2024
compiler/src/iree/compiler/Dialect/LinalgExt/IR/LinalgExtOps.td
Outdated
Show resolved
Hide resolved
qedawkins
approved these changes
Oct 9, 2024
compiler/src/iree/compiler/Dialect/LinalgExt/Transforms/AggregatedOpInterfaceImpl.cpp
Outdated
Show resolved
Hide resolved
compiler/src/iree/compiler/Dialect/LinalgExt/Transforms/TilingInterfaceImpl.cpp
Outdated
Show resolved
Hide resolved
compiler/src/iree/compiler/Dialect/LinalgExt/Transforms/test/tiling.mlir
Outdated
Show resolved
Hide resolved
compiler/src/iree/compiler/Dialect/LinalgExt/Transforms/test/tiling.mlir
Show resolved
Hide resolved
compiler/src/iree/compiler/Dialect/LinalgExt/Transforms/test/tiling.mlir
Outdated
Show resolved
Hide resolved
hanhanW
approved these changes
Oct 9, 2024
Max191
force-pushed
the
expanded-im2col-op
branch
from
7a3733d
to
332a73e
Compare
Signed-off-by: Max Dawkins <max.dawkins@gmail.com>
Signed-off-by: Max Dawkins <max.dawkins@gmail.com>
Signed-off-by: Max Dawkins <max.dawkins@gmail.com>
Signed-off-by: Max Dawkins <max.dawkins@gmail.com>
Signed-off-by: Max Dawkins <max.dawkins@gmail.com>
Signed-off-by: Max Dawkins <max.dawkins@gmail.com>
Max191
force-pushed
the
expanded-im2col-op
branch
from
332a73e
to
eda4108
Compare
Max191
added a commit
that referenced
this pull request
Oct 14, 2024
This is following up on #18593, which enabled support for expanded result shapes in the im2col op. This PR changes the rewrite patterns for conv into IGEMM to use the expanded H and W dimensions, rather than inserting collapse_shape and expand_shape ops. --------- Signed-off-by: Max Dawkins <max.dawkins@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for multiple M and K dimensions in the result of the im2col op. New metadata is added for correctly tracking the offsets into the M and K dimensions along the multiple dimensions. New
m_basisandk_basisfields are added to the op, which represent a basis for linearizing them_offsetandk_offsetfields.The motivation for doing this is that flattening the M dimension can create an expand_shape op consumer of the resulting matmul. This can cause issues with fusion and distribution, so it is useful to be able to keep the multiple M dimensions intact. This PR does not change any behavior of Conv2DToIm2col pass, which will be done in a later PR.