Lubridate related fix #108
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
irinagain
requested changes
Nov 15, 2022
| # rule = 1 means points outside of xmin/xmax will be NA (no extrapolation) | ||
| intervals <- list(nrow(missing)) | ||
| for (i in 1:nrow(missing)) { | ||
| grid = stats::approx(x = c(missing$start[i], missing$end[i]), |
There was a problem hiding this comment.
I am a little confused why you interpolate again. Line 175 above did all interpolation already (including over missing regions). So after the gaps are identified, new$y should be set to NA within gaps (no more interpolation).
There was a problem hiding this comment.
if my understanding is correct, then once you identified start/end times, you should be setting new$y directly to NA for elements corresponding to those times (new$x > start time and new$x < end time), does this make sense?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mag, meal_metrics, and lasagna_plots changes are just minor: integer instead of numeric, propagate tz, and capitalization respectively.
replacement of lubridate within is for checks as discussed