Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add LICENSE #144

Merged
merged 1 commit into from
Jun 26, 2024
Merged

feat: Add LICENSE #144

merged 1 commit into from
Jun 26, 2024

Conversation

matthewfeickert
Copy link
Member

  • Required for packaging on conda-forge, and should be included for general use.
    • When the sdist is built during packaging, the LICENSE file gets picked up, and then when the wheel is built from the sdist it is included in the wheel metadata directory.
  • MIT is chosen to match the stated license in the setup.py metadata:

func_adl/setup.py

Line 76 in 5f23cfb

license="MIT",

@matthewfeickert
feat: Add LICENSE
d6a6d68 
* Required for packaging on conda-forge, and should be included for
  general use.
   - When the sdist is built during packaging, the LICENSE file gets
   picked up, and then when the wheel is built from the sdist it is
   included in the wheel metadata directory.
@matthewfeickert matthewfeickert mentioned this pull request Apr 29, 2024
Closed
@gordonwatts gordonwatts self-requested a review June 26, 2024 08:55
@gordonwatts gordonwatts added the enhancement New feature or request label Jun 26, 2024
@gordonwatts gordonwatts merged commit 95b14c9 into iris-hep:master Jun 26, 2024
16 checks passed
@matthewfeickert matthewfeickert deleted the feat/add-LICENSE branch June 26, 2024 17:30
@matthewfeickert
Copy link
Member Author

Thanks @gordonwatts. Would you be able to make a v3.3.2 patch release for this to get picked up by ssl-hep/ServiceX_frontend#352?

@matthewfeickert
Copy link
Member Author

Would you be able to make a v3.3.2 patch release for this to get picked up by ssl-hep/ServiceX_frontend#352?

@gordonwatts Ping on this, though not a rush.

@matthewfeickert
Copy link
Member Author

@gordonwatts Though this week is busy, could you make a new patch release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gordonwatts gordonwatts Awaiting requested review from gordonwatts

Assignees

@matthewfeickert matthewfeickert

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matthewfeickert @gordonwatts