Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement the ROOTFiles return for the xAOD backend #5

Closed
gordonwatts opened this issue Sep 5, 2020 · 0 comments · Fixed by #11
Closed

Implement the ROOTFiles return for the xAOD backend #5

gordonwatts opened this issue Sep 5, 2020 · 0 comments · Fixed by #11
Assignees
@gordonwatts
Labels
enhancement New feature or request

Comments

@gordonwatts
Copy link
Member

The ASRootTree return for the uproot backend currently throws NotImplementedError.
@gordonwatts gordonwatts added the enhancement New feature or request label Sep 5, 2020
@gordonwatts gordonwatts mentioned this issue Sep 5, 2020
Closed
gordonwatts added a commit that referenced this issue Sep 23, 2020
@gordonwatts
Run with uproot and xAOD backends
1117493 
- Properly convert to parquet and awkward for the uproot backend (fixes 4) (fixes #3)
- Return root files for xaod (fixes #5)
- Organized handling differences between different backends (fixes #1)
- properly error out
- Properly hand off the xAOD or Uproot type.
- improve code coverage (fixes #6)
@gordonwatts gordonwatts self-assigned this Sep 24, 2020
@gordonwatts gordonwatts linked a pull request Sep 24, 2020 that will close this issue
Unify implimentations of uproot and xAOD backends #11
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gordonwatts gordonwatts

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Unify implimentations of uproot and xAOD backends iris-hep/func_adl_servicex
1 participant
@gordonwatts