Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic authentication options are incompatible with request lib #41

Open
marcboscher opened this issue Jan 2, 2015 · 0 comments
Open

Comments

@marcboscher
Copy link

In the original request lib, to use basic authentication you set auth.user and auth.pass in options

request.get('http://some.server.com/', {
  'auth': {
    'user': 'username',
    'pass': 'password',
    'sendImmediately': false
  }
});

Ref: https://www.npmjs.com/package/request#http-authentication

But browser-request expectsauth.username and auth.password. See

options.headers.authorization = 'Basic ' + b64_enc(options.auth.username + ':' + options.auth.password);

This breaks compatibility between the two libs.

pspeter3 added a commit to Asana/browser-request that referenced this issue Jan 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant