-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
merge v3.x to master branch #2945
Conversation
chore(docs): merger from master
fix: bump cosmos-sdk to v0.47.15-ics-lsm
WalkthroughIn version 3.1.0 of the IRISHub project, the major highlight is the upgrade of critical dependencies, including the cosmos-sdk to version v0.47.15-ics-lsm. These updates ensure enhanced stability, security, and feature support. Moreover, no alterations were made to the declarations of exported or public entities, maintaining backward compatibility. Changes
Poem
Tip Early access features: enabledWe are currently testing the following features in early access:
Note:
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Outside diff range and nitpick comments (4)
CHANGELOG.md (4)
Line range hint
153-153
: The date format "November 03th, 2021" should be corrected to "November 3rd, 2021".- *November 03th, 2021* + *November 3rd, 2021*
Line range hint
170-170
: The date format "April 21th, 2021" should be corrected to "April 21st, 2021".- *April 21th, 2021* + *April 21st, 2021*
Line range hint
364-364
: The date format "Aug 22th, 2019" should be corrected to "Aug 22nd, 2019".- *Aug 22th, 2019* + *Aug 22nd, 2019*
Line range hint
882-882
: The date format "September 22th, 2018" should be corrected to "September 22nd, 2018".- *September 22th, 2018* + *September 22nd, 2018*
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
go.sum
is excluded by!**/*.sum
Files selected for processing (2)
- CHANGELOG.md (1 hunks)
- go.mod (11 hunks)
Additional context used
LanguageTool
CHANGELOG.md
[duplication] ~144-~144: Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Context: ....com//pull/2734) Bump up TIBC-Go * [TIBC-Go #247](https://github.com/bianjieai/tib...
[style] ~149-~149: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...uirements in a more flexible manner. * [irismod #269](https://github.com/irisnet/irism...
[inconsistency] ~153-~153: The suffix does not match the ordinal number. (ORDINAL_NUMBER_SUFFIX)
Context: ...ulti Token) module ## 1.2.0 November 03th, 2021 ### Application * [#2681](htt...
[inconsistency] ~170-~170: The suffix does not match the ordinal number. (ORDINAL_NUMBER_SUFFIX)
Context: ...e new REST endpoints. ## 1.1.1 April 21th, 2021 ### Application * [#2611](htt...
[style] ~261-~261: Unless you want to emphasize “not”, use “cannot” which is more common. (CAN_NOT_PREMIUM)
Context: ...es/2109) Fix the bug that the hash lock can not be specified in the CLI ### Applicatio...
[inconsistency] ~270-~270: The suffix does not match the ordinal number. (ORDINAL_NUMBER_SUFFIX)
Context: ...sing rootstore version ## 0.16.0 Nov 22th, 2019 ### Breaking Changes * [API Br...
[inconsistency] ~347-~347: The suffix does not match the ordinal number. (ORDINAL_NUMBER_SUFFIX)
Context: ...x the p2p panic error. ## 0.15.3 Oct 2th, 2019 ### Tendermint Bump Tendermint...
[inconsistency] ~364-~364: The suffix does not match the ordinal number. (ORDINAL_NUMBER_SUFFIX)
Context: ...g on replay-last-block ## 0.15.1 Aug 22th, 2019 ### Application * [#1895](htt...
[inconsistency] ~433-~433: The suffix does not match the ordinal number. (ORDINAL_NUMBER_SUFFIX)
Context: ...d mempool memory usage ## 0.14.1 May 31th, 2019 ### LCD (REST API) * [#1486](...
[inconsistency] ~492-~492: The suffix does not match the ordinal number. (ORDINAL_NUMBER_SUFFIX)
Context: ...) Improve v0.13.1 docs ## 0.13.1 Mar 22th, 2019 ### LCD (REST API) * [#1339](...
[inconsistency] ~595-~595: The suffix does not match the ordinal number. (ORDINAL_NUMBER_SUFFIX)
Context: ...multiple times ## 0.11.0-rc0 January 21th, 2019 * [iris] Move the upgrade tally...
[grammar] ~650-~650: The word “setup” is a noun. The verb is spelled with a white space. (NOUN_VERB_CONFUSION)
Context: ... and implement the governance module to setup the new voting, tally, and penalty rule...
[grammar] ~704-~704: The word ‘withdraw’ is not a noun. Did you mean “withdrawal”? (PREPOSITION_VERB)
Context: ...sal cmd * Add withdraw address into the withdraw tags list * Fix the monitor bug ## 0.9...
[inconsistency] ~882-~882: The suffix does not match the ordinal number. (ORDINAL_NUMBER_SUFFIX)
Context: ...ns of the irisnet ## 0.4.2 September 22th, 2018 BUG FIXES * Fix consensus fail...
Markdownlint
CHANGELOG.md
969-969: Expected: atx; Actual: atx_closed (MD003, heading-style)
Heading style
990-990: Expected: atx; Actual: atx_closed (MD003, heading-style)
Heading style
990-990: null (MD024, no-duplicate-heading)
Multiple headings with the same content
106-106: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading
117-117: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading
139-139: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading
153-153: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading
170-170: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading
179-179: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading
194-194: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading
206-206: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading
241-241: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading
249-249: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading
257-257: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading
270-270: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading
331-331: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading
339-339: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading
347-347: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading
355-355: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading
364-364: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading
373-373: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading
433-433: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading
446-446: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading
492-492: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading
526-526: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading
534-534: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading
540-540: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading
557-557: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading
564-564: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading
581-581: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading
595-595: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading
618-618: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading
624-624: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading
631-631: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading
642-642: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading
687-687: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading
693-693: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading
700-700: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading
709-709: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading
741-741: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading
747-747: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading
767-767: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading
776-776: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading
815-815: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading
824-824: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading
846-846: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading
858-858: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading
882-882: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading
890-890: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading
898-898: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading
931-931: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading
939-939: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading
950-950: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading
973-973: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading
Additional comments not posted (12)
go.mod (11)
8-8
: Updatedgithub.com/cometbft/cometbft
tov0.37.5
. Please ensure compatibility with existing systems and check for any breaking changes in this version.
10-10
: Updatedgithub.com/cosmos/cosmos-sdk
tov0.47.15-ics-lsm
. Ensure that all modules and integrations that depend on this SDK are tested thoroughly to avoid integration issues.
23-23
: Updatedgithub.com/cosmos/cosmos-proto
tov1.0.0-beta.5
. As this is a beta version, please ensure it's stable enough for production use and compatible with other cosmos modules.
24-24
: Updatedgithub.com/golang/protobuf
tov1.5.4
. Verify that there are no deprecations or breaking changes that could impact the project.
28-28
: Updatedgithub.com/spf13/cast
tov1.6.0
. Ensure that this update does not affect any type conversions or data handling in the project.
29-29
: Updatedgithub.com/spf13/cobra
tov1.8.0
. Check all CLI commands and flags to ensure they function correctly with this new version.
31-31
: Updatedgithub.com/stretchr/testify
tov1.9.0
. Please run all unit tests to confirm that there are no regressions or issues with the new version.
34-34
: Updatedgoogle.golang.org/genproto
tov0.0.0-20240123012728-ef4313101c80
. Confirm that all generated protobuf files are compatible with this version and function correctly.
35-35
: Updatedgoogle.golang.org/grpc
tov1.62.1
. It's crucial to test all gRPC endpoints to ensure they are stable and perform as expected with this update.
36-36
: Updatedgoogle.golang.org/protobuf
tov1.33.0
. Ensure that this version is compatible with the updatedgenproto
and that all protobuf definitions are correctly handled.
46-46
: Updatedgithub.com/spf13/viper
tov1.18.2
. Verify that all configurations are correctly loaded and parsed with this new version.CHANGELOG.md (1)
5-7
: The update to cosmos-sdk to version v0.47.15-ics-lsm is appropriately documented as a state machine breaking change. Ensure that all dependent modules and integrations are tested against this new version to avoid runtime issues.
chores:merge from master
Summary by CodeRabbit