Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature/OPT-780] to dev #223

Merged
merged 8 commits into from
May 9, 2023
Merged

[feature/OPT-780] to dev #223

merged 8 commits into from
May 9, 2023

Conversation

smaneroiriusrisk
Copy link
Contributor

No description provided.

@dantolin-iriusrisk
Copy link
Collaborator

dantolin-iriusrisk commented Apr 12, 2023 •
edited
Loading

As general comments:

  • To be coherent with the naming, we should rename the strategies.dataflow package to strategies.connector.
  • Now we have well separated the responsibilities, I would implement unit tests for the new strategy classes under strategies.dataflow.impl.

@PacoCid PacoCid merged commit 0dfa56d into dev May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dantolin-iriusrisk dantolin-iriusrisk dantolin-iriusrisk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@smaneroiriusrisk @dantolin-iriusrisk @PacoCid