Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

weak references: Daemon.register(...,weak=True) #50

Merged
merged 6 commits into from
Sep 13, 2021
Merged

weak references: Daemon.register(...,weak=True) #50

merged 6 commits into from
Sep 13, 2021

Conversation

eudoxos
Copy link
Contributor

@eudoxos eudoxos commented Jul 23, 2021

As discussed in #47 . Please review :)

@eudoxos eudoxos mentioned this pull request Jul 23, 2021
Closed
irmen
irmen requested changes Sep 12, 2021
View reviewed changes
Copy link
Owner

@irmen irmen left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

after consideration I rather have the explicit weak=True parameter, so please undo the last commit

@irmen
Copy link
Owner

irmen commented Sep 13, 2021

looks good, thanks!

@irmen irmen merged commit 0fa521d into irmen:master Sep 13, 2021
@eudoxos eudoxos mentioned this pull request Jun 29, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@irmen irmen irmen requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eudoxos @irmen