Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[42] dashboard doesn't need to use audit_ namespace anymore #43

Merged
merged 1 commit into from
May 20, 2024

Conversation

trel
Copy link
Member

@trel trel commented May 12, 2024

confirmed dashboard works as before, but now without using the audit_ namespace - so... faster, less configuration, and easier to teach/understand.

Copy link
Member

@SwooshyCueb SwooshyCueb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as you've built and tested a container with this change, it's got my stamp of approval.

Copy link

@alanking alanking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If confirmed working, let's squash and add the issue number.

@trel
Copy link
Member Author

trel commented May 17, 2024

will do - thanks

@trel
Copy link
Member Author

trel commented May 17, 2024

squashed and numbered. still to be confirmed hands-free...

@alanking
Copy link

I'll take a shot at confirmation, hopefully later today.

@alanking
Copy link

Just tried this out and everything seems to be working as expected. Here's my REP configuration:

        "rule_engines": [
            {
                "instance_name": "irods_rule_engine_plugin-irods_rule_language-instance",
                "plugin_name": "irods_rule_engine_plugin-irods_rule_language",
                "plugin_specific_configuration": {
                    "re_data_variable_mapping_set": [
                        "core"
                    ],
                    "re_function_name_mapping_set": [
                        "core"
                    ],
                    "re_rulebase_set": [
                        "data_to_compute",
                        "core"
                    ],
                    "regexes_for_supported_peps": [
                        "ac[^ ]*",
                        "msi[^ ]*",
                        "[^ ]*pep_[^ ]*_(pre|post|except|finally)"
                    ]
                },
                "shared_memory_instance": "irods_rule_language_rule_engine"
            },
            {
                "instance_name": "irods_rule_engine_plugin-audit_amqp-instance",
                "plugin_name": "irods_rule_engine_plugin-audit_amqp",
                "plugin_specific_configuration" : {
                     "amqp_location" : "ANONYMOUS@localhost:5672",
                     "amqp_topic" : "audit_messages",
                     "pep_regex_to_match" : "pep_(api|resource)_.*"
                 }
           },
            {
                "instance_name": "irods_rule_engine_plugin-cpp_default_policy-instance",
                "plugin_name": "irods_rule_engine_plugin-cpp_default_policy",
                "plugin_specific_configuration": {}
            }
        ]
    },
    "rule_engine_namespaces": [
        ""
    ],

@trel
Copy link
Member Author

trel commented May 20, 2024

excellent. will # this one...

and make the slides do what you did there... and i think we're good. thanks.

@trel
Copy link
Member Author

trel commented May 20, 2024

#'d

@alanking alanking merged commit 5e44ecf into irods:main May 20, 2024
1 check was pending
@alanking
Copy link

Slides updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants