[several] Ubuntu 24.04 support + various improvements (4-3-stable) #7739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 10, 2024
SwooshyCueb
force-pushed
the
noble.4-3-stable
branch
2 times, most recently
from
63bca34
to
8c91990
Compare
SwooshyCueb
force-pushed
the
noble.4-3-stable
branch
2 times, most recently
from
e9f1f2e
to
93087bd
Compare
SwooshyCueb
force-pushed
the
noble.4-3-stable
branch
from
555393d
to
e11fa94
Compare
SwooshyCueb
changed the title
SwooshyCueb
force-pushed
the
noble.4-3-stable
branch
from
eb74704
to
7665e89
Compare
SwooshyCueb
changed the title
|
Tests are passing! This PR is ready for review. |
|
Will get to this after UGM. |
SwooshyCueb
force-pushed
the
noble.4-3-stable
branch
4 times, most recently
from
a0c51cf
to
708ec45
Compare
|
Are there any differences between this PR and the one for the main branch? |
|
A quick eyeballing of the diff yields results unrelated to these changes (i.e. they are differences between main and 4-3-stable in general). Will await word from @SwooshyCueb |
Nope, they are the same |
…egin` to `void`
…n deb packages
…for regex patterns
…unordered_map`
- `typedef`s converted to `using`s
- type aliases added
- `key_type`
- `value_type`
- `size_type`
- `hasher`
- `iterator_value_type`
- `const_iterator_value_type`
- references to template type arguments in member function declarations swapped for aliases
- `operator[](key_type)` overload replaced with `operator[](const key_type&)` and `operator[](key_type&&)`
- `size()` is now `noexcept` and returns `size_type` instead of `int`
- `has_entry(key_type)` overload replaced with `has_entry(const key_type&)`
- `erase(key_type)` overload replaced with `erase(const key_type&)` that returns `size_type` instead of `size_t`
- `clear()` is now `noexcept`
- `empty()` is now `noexcept` and `nodiscard`
- `begin()` and `end()` are now `noexcept` and have `const` overloads that return a `const_iterator`
- `cbegin()` and `cend()` are now `noexcept`
- `find(key_type)` overload replaced with `find(const key_type&)` and a `const` overload that returns a `const_iterator`
- `get()` implementaiton optimized - uses `find()` instead of `has_entry()`, allowing re-use of the iterator.
- `set()` implementation now calls `insert_or_assign()` instead of the `[]` operator.
The implementation is now more similar to that of `std::unordered_map`.
Most of the signal handlers set by `irods::set_unrecoverable_signal_handlers()` can now be disabled by setting the environment variable `IRODS_DISABLE_CRASH_SIGNAL_HANDLERS`. This is useful for debugging utilities that inject their own signal handlers.
…patibility code
…_msiServerMonPerf_default_3736` This test is made redunant by `test_all_rules.Test_AllRules.test_rulemsiServerMonPerf_r`
SwooshyCueb
force-pushed
the
noble.4-3-stable
branch
from
708ec45
to
41b42e2
Compare
|
#'d |
korydraughn
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #7733
In service of #7592
Addresses #7729
Addresses #7730
Addresses #7731
Addresses #7732
Addresses #7735
Addresses #7736
Addresses #7740
Addresses #7741
Addresses #7743
Addresses #7744
Addresses #7745
Addresses #7747
Addresses #7750
Addresses #7754
Addresses #7755
Addresses #7756
Companion PRs: