add host and port, convenient loading the config manually via ConfigWith... #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -69,7 +69,7 @@ func New(queueName string) *Queue { | |||
| return &Queue{Settings: config.Config("iron_mq"), Name: queueName} | |||
| } | |||
|
|
|||
| func ListProjectQueues(projectId string, token string, page int, perPage int) (queues []Queue, err error) { | |||
| func ListProjectQueues(projectId string, token string, host string, port uint16, page int, perPage int) (queues []Queue, err error) { | |||
There was a problem hiding this comment.
Hey, looks great. could we make separate method instead with the extra parameters? don't want to break clients' codes. thanks
hayate
changed the title
hayate
changed the title
|
thanks! |
rdallman
pushed a commit
that referenced
this pull request
Nov 29, 2014
add host and port, convenient loading the config manually via ConfigWith...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...Env