Solved the Great Response Crisis of Week 8 #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Shoutout to @Ogeon - thanks for your help. |
zzmp
added a commit
that referenced
this pull request
Jun 16, 2014
Solved the Great Response Crisis of Week 8
| writer: writer | ||
| } | ||
| ) | ||
| } |
There was a problem hiding this comment.
Why are you transmuting this to what it already is? This is a bit risky and it could be avoided by defining the trait as
pub trait HttpResponse<'a, 'b> {
fn from_http(&'a mut ResponseWriter<'b>) -> Self;
}There was a problem hiding this comment.
This was my original approach (you can see the remains on my great-response-crisis branch of my fork, if you're curious) but that doesn't work for the reasons @zzmp discussed with you on #iron last night.
|
I'm working on this in my fork's bug/lifetime-response branch. It may be a good starting-off point, though it does not compile. |
phlmn
pushed a commit
to phlmn/iron
that referenced
this pull request
Oct 19, 2018
Move entirely to Cargo
phlmn
pushed a commit
to phlmn/iron
that referenced
this pull request
Oct 19, 2018
(feat) HTTPS for rustup
phlmn
pushed a commit
to phlmn/iron
that referenced
this pull request
Oct 18, 2019
Updates for upstream Iron changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By coercing lifetimes instead of types and moving from_http to its own trait, we have
managed to both allow new Response representations and remove all the lifetimes from
everywhere.
Such is the power of Sundays.