Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance #277

Merged
merged 12 commits into from
Feb 26, 2024
Merged

Maintenance #277

merged 12 commits into from
Feb 26, 2024

Conversation

aobort
Copy link
Contributor

@aobort aobort commented Feb 26, 2024

What this PR does / why we need it:

  • rework Makefile
  • rework code generation
  • fix tests after linters run
  • re-structure api folder to make code generators work properly: the initial folder structure was ../api/v1alpha1/.... However, client-gen tool expects structure like ../api/{group-name}/{version}/.... Running tool with initial structure makes it add the group name core (I guess this is due to native kubernetes group-versions), thus it tries to import api package with invalid name - github.com/ironcore-dev/ipam/api/core/v1alpha1 which does not exist. To solve it, api types were moved to ../api/ipam/v1alpha1 folder.

Which issue(s) this PR fixes:
Fixes 276

Release note:

api package restructured
add support of code-generators: applyconfigurations-gen, client-gen, lister-gen, informer-gen etc

Signed-off-by: Artem Bortnikov <artem.bortnikov@telekom.com>
Signed-off-by: Artem Bortnikov <artem.bortnikov@telekom.com>
Signed-off-by: Artem Bortnikov <artem.bortnikov@telekom.com>
Signed-off-by: Artem Bortnikov <artem.bortnikov@telekom.com>
Signed-off-by: Artem Bortnikov <artem.bortnikov@telekom.com>
@aobort aobort requested review from damyan and removed request for rahulppawar February 26, 2024 10:07
@damyan damyan merged commit c71a71b into ironcore-dev:main Feb 26, 2024
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants